Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation for manifest 1.4 #87347

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Nov 3, 2022

Creating as draft for later merge

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

ItzLevvie
ItzLevvie previously approved these changes Nov 8, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 8, 2022
@ghost ghost removed Moderator-Approved One of the Moderators has reviewed and approved this PR Unexpected-File labels Jan 7, 2023
@ghost ghost removed the Unexpected-File label Jan 7, 2023
ItzLevvie
ItzLevvie previously approved these changes Jan 7, 2023
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 7, 2023
@ghost ghost removed Moderator-Approved One of the Moderators has reviewed and approved this PR Unexpected-File labels Jan 23, 2023
@Trenly Trenly marked this pull request as ready for review January 23, 2023 19:38
@Trenly
Copy link
Contributor Author

Trenly commented Jan 23, 2023

cc @stephengillie

@ghost
Copy link

ghost commented Jan 23, 2023

Trenly,

Changes to one or more files in your PR require authorization to modify. This PR has been assigned to our on call staff to evaluate.

Template: msftbot/requiresApproval/MSFT

@ghost ghost assigned stephengillie and ryfu-msft Jan 23, 2023
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 23, 2023
@Trenly
Copy link
Contributor Author

Trenly commented Jan 24, 2023

@stephengillie - Probably needs to be manually merged since there isn't a pipeline run associated with project files

@stephengillie stephengillie merged commit eee108f into microsoft:master Jan 24, 2023
@Trenly Trenly deleted the Docs1.4 branch January 24, 2023 18:32
@denelon
Copy link
Contributor

denelon commented Jan 24, 2023

@Trenly I think the PR template and the updates to the fabricbot.json were a bit premature.

Have you seen any 1.4 manifests pass automated validation? If you have, then that's a different issue for me to track down 😊

@Trenly
Copy link
Contributor Author

Trenly commented Jan 24, 2023

@Trenly I think the PR template and the updates to the fabricbot.json were a bit premature.

Have you seen any 1.4 manifests pass automated validation? If you have, then that's a different issue for me to track down 😊

@denelon - My mistake; I thought those were in a separate PR. I haven't seen any 1.4 pass validation, but they are all marked with Manifest-Validation-Error. Do you think we should roll back, or just wait this one out. Based on what I've seen in the recent submissions, since Wingetcreate and YamlCreate are both still using 1.2, there hasn't been any confusion

@denelon
Copy link
Contributor

denelon commented Jan 24, 2023

I'm OK to try and let it stand. As long as it doesn't cause too much confusion.

@denelon
Copy link
Contributor

denelon commented Jan 24, 2023

Worst case, I think we just roll back the fabricbot.json and the PR template.
One of our internal teams got confused and reached out to me.

@Trenly
Copy link
Contributor Author

Trenly commented Jan 24, 2023

Worst case, I think we just roll back the fabricbot.json and the PR template.
One of our internal teams got confused and reached out to me.

My apologies once again; I'll monitor the pipelines over the next few days, but if any other items come up on your end just @ me and I'll create a revert commit, and then we can revert the revert once everything is ready

@denelon
Copy link
Contributor

denelon commented Jan 24, 2023

No worries, we should have caught and handled this one slightly differently :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants