-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for manifest 1.4 #87347
Conversation
Trenly, Changes to one or more files in your PR require authorization to modify. This PR has been assigned to our on call staff to evaluate. Template: msftbot/requiresApproval/MSFT |
@stephengillie - Probably needs to be manually merged since there isn't a pipeline run associated with project files |
@Trenly I think the PR template and the updates to the fabricbot.json were a bit premature. Have you seen any 1.4 manifests pass automated validation? If you have, then that's a different issue for me to track down 😊 |
@denelon - My mistake; I thought those were in a separate PR. I haven't seen any 1.4 pass validation, but they are all marked with Manifest-Validation-Error. Do you think we should roll back, or just wait this one out. Based on what I've seen in the recent submissions, since Wingetcreate and YamlCreate are both still using 1.2, there hasn't been any confusion |
I'm OK to try and let it stand. As long as it doesn't cause too much confusion. |
Worst case, I think we just roll back the fabricbot.json and the PR template. |
My apologies once again; I'll monitor the pipelines over the next few days, but if any other items come up on your end just @ me and I'll create a revert commit, and then we can revert the revert once everything is ready |
No worries, we should have caught and handled this one slightly differently :) |
Creating as draft for later merge
Microsoft Reviewers: Open in CodeFlow