Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved: Tricentis.NeoLoad version 8.0.0 #66948

Merged
3 commits merged into from
Jul 21, 2022
Merged

Moved: Tricentis.NeoLoad version 8.0.0 #66948

3 commits merged into from
Jul 21, 2022

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Jul 20, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost exactly what I was thinking; I would just recommend adding these additional fields to help ensure the ARP match causes the transition

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 20, 2022
@ghost ghost assigned mdanish-kh Jul 20, 2022
@ghost
Copy link

ghost commented Jul 20, 2022

Hello @mdanish-kh,
The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Jul 20, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 20, 2022
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. Possible-Duplicate labels Jul 20, 2022
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: dd53489353be8f8360c95a6d06d3722497c903904d4573e32cc858d8d4a7b57c
    • manifests\n\Neotys\NeoLoad\8.0.0
  • InstallerSha256: 4ae8e71988ec4083e8cfa83867fdd453a0f0f1048f4b4f0cc3b18356d714e484
    • manifests\n\Neotys\NeoLoad\8.0.0

@ghost ghost assigned JohnMcPMS and yao-msft Jul 20, 2022
@ghost
Copy link

ghost commented Jul 20, 2022

@mdanish-kh,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 20, 2022
@Trenly
Copy link
Contributor

Trenly commented Jul 20, 2022

@JohnMcPMS @yao-msft - This is an intentional duplicate with different Publisher Data to cover the upgrade scenario as Netoys has been acquired by Tricentis. Original package has a waiver for Validation-Domain in the directory - https://github.com/microsoft/winget-pkgs/tree/master/manifests/n/Neotys/NeoLoad

@JohnMcPMS
Copy link
Member

@wingetbot waivers Add Validation-Domain

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Jul 21, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 21, 2022
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 4ae8e71988ec4083e8cfa83867fdd453a0f0f1048f4b4f0cc3b18356d714e484
    • manifests\n\Neotys\NeoLoad\8.0.0
  • InstallerSha256: dd53489353be8f8360c95a6d06d3722497c903904d4573e32cc858d8d4a7b57c
    • manifests\n\Neotys\NeoLoad\8.0.0

@ghost
Copy link

ghost commented Jul 21, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 21, 2022

Hello mdanish-kh,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit f23e94e into microsoft:master Jul 21, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@mdanish-kh mdanish-kh deleted the Tricentis.NeoLoad-8.0.0-Moved branch July 22, 2022 17:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Possible-Duplicate Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Domain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants