Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1 of 2 'alpha'-designated version of 7-Zip from non-alpha listing #3762

Merged
4 commits merged into from
Sep 30, 2020

Conversation

peterlewis
Copy link
Contributor

@peterlewis peterlewis commented Sep 27, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

PR to follow #3756

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Sep 27, 2020
@ghost
Copy link

ghost commented Sep 27, 2020

peterlewis The package manager bot determined there was an issue with the pull request. Make sure the manifest file is under the manifests\publisher\appname.
For details on the error, see the details link below in the build pipeline.

@peterlewis
Copy link
Contributor Author

Have included removal of both alpha versions in a single PR. I'm aware from what @yigitemres mentioned that a single file change per PR is preferred, but not sure if that includes deletions, such as this.

If it does then do just holler, and I'll split into two.

@peterlewis peterlewis marked this pull request as ready for review September 29, 2020 08:22
@peterlewis
Copy link
Contributor Author

Hey @KevinLaMS - Here's the other part of the 7-Zip change, i.e. removing the alpha releases from the main listing.

@KevinLaMS
Copy link
Contributor

@peterlewis Great, thanks.
To get past automation, can you have 1 delete manifest per PR.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed the Needs: Attention label Sep 30, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterlewis
Copy link
Contributor Author

Hah, now you're testing my Git-fu! Think I've managed to do what is required, albeit followed by a revert and then a revert of the revert! :)

@peterlewis peterlewis changed the title Remove 'alpha'-designated versions of 7-Zip from non-alpha listing Remove 1 of 2 'alpha'-designated version of 7-Zip from non-alpha listing Sep 30, 2020
@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Sep 30, 2020
@ghost ghost assigned KevinLaMS Sep 30, 2020
@ghost
Copy link

ghost commented Sep 30, 2020

This submission has moved to manual review.

@peterlewis
Copy link
Contributor Author

PR for the other file is in as #3807

@ghost
Copy link

ghost commented Sep 30, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit e939bfc into microsoft:master Sep 30, 2020
@peterlewis peterlewis deleted the patch-3 branch September 30, 2020 15:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants