Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 7-Zip 20.02 Alpha in separate listing #3756

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

peterlewis
Copy link
Contributor

@peterlewis peterlewis commented Sep 27, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterlewis
Copy link
Contributor Author

peterlewis commented Sep 27, 2020

Hey @KevinLaMS!

Before I un-draft this PR, can I just check you're happy with the structure of the name? I'm still yet to test this locally, so will do that too before un-drafting, obviously.

It appears that on the official website, the versioning is stylised as 20.02 Alpha, whereas, given that 'alpha' is included in the software name, I simply versioned it as 20.0.2 without any -alpha suffixed.

Regarding the additional decimal, I simply followed the existing. Without having dug-through the previous PRs, I'm guessing that a leading zero doesn't work...

Thanks!

Peter

P.S. Please do let me know if you'd like me to bring across the superceded alpha version, for completeness-sake.

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Sep 27, 2020
@ghost ghost assigned denelon Sep 27, 2020
@ghost
Copy link

ghost commented Sep 27, 2020

This submission has moved to manual review.

@ghost ghost removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Sep 27, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Sep 27, 2020
@ghost ghost assigned KevinLaMS Sep 27, 2020
@ghost
Copy link

ghost commented Sep 27, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Sep 27, 2020
@ghost
Copy link

ghost commented Sep 27, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@KevinLaMS KevinLaMS marked this pull request as ready for review September 28, 2020 19:55
@KevinLaMS KevinLaMS merged commit aacf391 into microsoft:master Sep 28, 2020
@peterlewis peterlewis deleted the patch-2 branch September 29, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants