Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: TheDocumentFoundation.LibreOffice.LTS version 7.6.4 #138502

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Feb 9, 2024

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 9, 2024
@stephengillie
Copy link
Collaborator

Hi @CoolPlayLin,

This PR's version number 7.6.4 has 3 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 7.5.9.2, which has 4 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)

(Automated response - build 720)

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo. labels Feb 9, 2024
@Mat2095
Copy link
Contributor

Mat2095 commented Feb 10, 2024

Hm, could this lead to issues, if two packages (TheDocumentFoundation.LibreOffice and TheDocumentFoundation.LibreOffice.LTS) both have the same version of the same application, meaning identical installer, product-code and so on? At the moment there is no overlap in versions yet.

@stephengillie
Copy link
Collaborator

Hi @Trenly and @mdanish-kh,

What are your thoughts on having duplicate installer details in 2 different PackageIdentifiers, as described by @Mat2095?

Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After committing the suggested changes, you would also have to rename the version folder to match the new PackageVersion. The folder under manifests/t/TheDocumentFoundation/LibreOffice/LTS should be renamed from 7.6.4 -> 7.6.4.1

A quick and easy way to do this would be here in GitHub Web by pressing the . (dot) key on your keyboard that'll open up the PR in VS Code Online. Navigate to Explorer menu, find the required folder and make the appropriate rename changes.

After that, stage and commit your changes from Source Control menu on the left. (The changes are automatically pushed)

# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.5.0.schema.json

PackageIdentifier: TheDocumentFoundation.LibreOffice.LTS
PackageVersion: 7.6.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 7.6.4
PackageVersion: 7.6.4.1

# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.5.0.schema.json

PackageIdentifier: TheDocumentFoundation.LibreOffice.LTS
PackageVersion: 7.6.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 7.6.4
PackageVersion: 7.6.4.1

# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.5.0.schema.json

PackageIdentifier: TheDocumentFoundation.LibreOffice.LTS
PackageVersion: 7.6.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageVersion: 7.6.4
PackageVersion: 7.6.4.1

@mdanish-kh
Copy link
Contributor

Hi @ Trenly and @ mdanish-kh,

What are your thoughts on having duplicate installer details in 2 different PackageIdentifiers, as described by @ Mat2095?

If I'm understanding this correctly - 7.6.4.1 has recently become an LTS version? If that is the case, we can consider removing it first from TheDocumentFoundation.LibreOffice package id, and then merge in this PR.

@Mat2095
Copy link
Contributor

Mat2095 commented Feb 13, 2024

If I'm understanding this correctly - 7.6.4.1 has recently become an LTS version? If that is the case, we can consider removing it first from TheDocumentFoundation.LibreOffice package id, and then merge in this PR.

Yes, 7.6.4.1 is the current LTS version (since ~2 weeks).
Could removing this version from TheDocumentFoundation.LibreOffice lead to an issue like the following?

  • user installed TheDocumentFoundation.LibreOffice 7.6.4.1 in the past
  • it gets removed and added to TheDocumentFoundation.LibreOffice.LTS
  • user searches for updates and now receives updates from TheDocumentFoundation.LibreOffice.LTS instead of TheDocumentFoundation.LibreOffice

@mdanish-kh
Copy link
Contributor

Yes, 7.6.4.1 is the current LTS version (since ~2 weeks). Could removing this version from TheDocumentFoundation.LibreOffice lead to an issue like the following?

* user installed `TheDocumentFoundation.LibreOffice` `7.6.4.1` in the past

* it gets removed and added to `TheDocumentFoundation.LibreOffice.LTS`

* user searches for updates and now receives updates from `TheDocumentFoundation.LibreOffice.LTS` instead of `TheDocumentFoundation.LibreOffice`

Ah yes, I believe that is going to be a side-effect of this change. Not sure what's more valuable - keeping existing users to get releases from the same "channel" they installed from, or correctly reflecting the status of each version in the repository. I'm inclining towards the second option, not the most ideal for existing users, but winget list libreoffice will help them see that they're now on the LTS version. cc @Trenly thoughts?

I think the actual solution would be implementation of proper channel support in winget:

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Feb 19, 2024
Copy link
Contributor

Hello @CoolPlayLin,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

auto-merge was automatically disabled February 22, 2024 14:52

Pull request was closed

auto-merge was automatically disabled February 22, 2024 14:52

Pull request was closed

@Mat2095
Copy link
Contributor

Mat2095 commented Feb 22, 2024

@mdanish-kh Well, in the meantime 7.6.5 has been released. That version does not exist (and never existed) for the TheDocumentFoundation.LibreOffice package, so it does not create any issues. So I will close my issue for 7.6.4 LTS and hopefully I can manage to create a PR myself :)

@microsoft-github-policy-service microsoft-github-policy-service bot removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Feb 22, 2024
@CoolPlayLin CoolPlayLin deleted the TheDocumentFoundation.LibreOffice.LTS-7.6.4-ae891edc-54a6-4544-82cf-7d777006d997 branch March 31, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed Version-Parameter-Mismatch This manifest's package version has a different number of parameters than the newest in repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: LibreOffice.LTS 7.6.4
5 participants