Upgrade does not work properly on auto-updating apps

[derkrasseleo]

Brief description of your issue

Discord updated itself to version 1.0.9002 but winget doen't realise and thinks there is an update. When I do winget upgrade I get an Update for Discord but when I try to upgrade discord it says nothing to update. That could be confusing and could cause issues with self-updating apps.

Steps to reproduce

1. winget upgrade
2. winget upgrade discord or winget upgrade discord.discord

Expected behavior

Updating discord to the newest version or ignoring the upgrade when a newer version is already installed.

Actual behavior

Discord doen't get updated / doesn't check wich version is installed?

Environment

[winget --info]
v1.0.11451

Windows: Edition	Windows 10 Pro
Version	21H1
Build	19043.1023
Windows Feature Experience Pack 120.2212.3740.0

Package: Discord Discord.Discord 1.0.9001 1.0.9002  winget

[JustMyGithub]

I think the question is how winget can determine the correct version. Maybe the manifest can reference a PE-file with has the correponding file version set, but that would probably mean that it only works for applications installed in their default directory.

[denelon]

This appears to be related to the metadata in the manifest or the package itself. This depends on what version is stated in the latest manifest as well as the version the package reports in Add / Remove Programs.

[denelon]

Is this still an issue? Hopefully Discord is reporting the version and the manifest is correctly determining when an update is available.

[rgdyy]

I think a number of packages have this issue. In my case, they include Zotero.Zotero, Tencent.WeChat at least. This also happens for CondaForge.Mambaforge (so I guess also for other conda related packages). They don't report updated version to Windows Add / Remove Programs if updated within app.

[denelon]

If packages are updating themselves, they can be excluded from winget upgrade --all by default if the "requireExplicitUpgrade" is specified in the manifest.

[rgdyy]

So this is up to the package authors?

If packages are updating themselves, they can be excluded from winget upgrade --all by default if the "requireExplicitUpgrade" is specified in the manifest.

[denelon]

It would be changes to the manifests, or changes to the installers to improve the behavior during the upgrade process. The change in the manifest essentially just pushes the problem out of impact for winget upgrade --all, but the explicit winget upgrade <package> could still cause a bad experience if the installer isn't designed to support a graceful upgrade when run in silent mode.

[rollingmoai]

• Upstream issue: Product version not updated after application update Squirrel/Squirrel.Windows#1187

[Trenly]

I'm going to close this issue as a stale issue since it is up to the applications themselves to write the proper version information into the registry. WinGet has several features to help when this case is present such as requireExplicitUpgrade, the winget pin command, and now a new UpgradeBehavior: deny that can be specified in manifests

If new applications have this issue, new issues specific to each package can be opened