-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Machine-Wide Installer from the actual program #14115
Comments
I don't mind splitting it (if it would fix this case, which I'm not 100% sure of since it seems like somethings up with how Just spitballing, but maybe the next breaking change to the schema should make the ProductCode, PackageName (or AppName as was recommended in microsoft/winget-cli#982) and PackageVersion attributes arrays? My brain is too tired to think about how that would break stuff at the moment, but that seems like a solution to a ton of the matching issues we're experiencing. |
The reason Teams and Github came to mind is because i had those installed and they caused those problems until i uninstalled them 😋 |
But they are the same in that they both add multiple ARP entries for one installer, which is a scenario that needs to be thought about for install/upgrade. |
Programs that are not actually the program should be split into 2 different manifests.
The 2 programs that comes to mind at the moment is
GitHub Desktop
andMicrosoft Teams
As seen in this case for example microsoft/winget-cli#976 (comment) the
Machine-Wide Teams installer
is outdated, butMicrosoft Teams
it self is notIn
WinGet list
they both also appear underMicrosoft Teams
andGitHub Desktop
Therefore the best way to solve it would be to Split the
PackageIdentifier
toMicrosoft.Teams.Client
andMicrosoft.Teams.MachineWide
This issue is mainly for @jedieaston and @ItzLevvie with their big guns 😁
The text was updated successfully, but these errors were encountered: