Skip to content

Support Windows Package Manager v1.1 schema #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denelon opened this issue Aug 19, 2021 · 1 comment · Fixed by #218 or #224
Closed

Support Windows Package Manager v1.1 schema #139

denelon opened this issue Aug 19, 2021 · 1 comment · Fixed by #218 or #224
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Fix-Committed
Milestone

Comments

@denelon
Copy link
Contributor

denelon commented Aug 19, 2021

Description of the new feature/enhancement

The tool should support the new v1.1 schema. It should also be able to update v1.0 manifests to v1.1.

@denelon denelon added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 19, 2021
@ghost ghost added the Needs-Triage label Aug 19, 2021
@denelon denelon added this to the Backlog-Create milestone Oct 1, 2021
@OfficialEsco
Copy link

OfficialEsco commented Nov 18, 2021

This kinda needs to be prioritized if we update YamlCreate to 1.1.0.
Currently it removes Metadata, but keeps the "ManifestVersion: 1.1.0" and "$schema=" line
Example the new AnyDesk manifest

https://github.com/microsoft/winget-pkgs/blob/master/manifests/a/AnyDeskSoftwareGmbH/AnyDesk/ad%207.0.2/AnyDeskSoftwareGmbH.AnyDesk.installer.yaml

# Created with YamlCreate.ps1 v2.0.2 $debug=AUSU.7-2-0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.1.0.schema.json

PackageIdentifier: AnyDeskSoftwareGmbH.AnyDesk
PackageVersion: ad 7.0.2
Platform:
- Windows.Desktop
MinimumOSVersion: 10.0.0.0
Scope: machine
InstallModes:
- interactive
- silent
- silentWithProgress
Installers:
- Architecture: x86
  InstallerType: msi
  InstallerUrl: https://download.anydesk.com/AnyDesk.msi
  InstallerSha256: 307B2EC75D5A4DB865FFA253F482263F183E86E1BCF627CE65BB45CDFCB1C295
  ProductCode: '{62853EBF-E9DD-4AA5-B20A-5A6C3DD74FF3}'
  UpgradeBehavior: uninstallPrevious
  AppsAndFeaturesEntries:
  - DisplayName: AnyDesk MSI
  - DisplayVersion: 7.0.2
- Architecture: x86
  InstallerType: exe
  InstallerUrl: https://download.anydesk.com/AnyDesk.exe
  InstallerSha256: B95DF71D6ED6EC96FA0EB51BB33B9C5503696DF2C04CE69AE89E3EDEFD91558F
  InstallerSwitches:
    Silent: --silent
    SilentWithProgress: --silent
    Upgrade: --remove-first
    Custom: --install "C:\Program Files (x86)\AnyDesk" --update-auto --create-desktop-icon --create-shortcuts
  UpgradeBehavior: install
  ElevationRequirement: elevationRequired
  AppsAndFeaturesEntries:
  - DisplayName: AnyDesk
  - DisplayVersion: ad 7.0.2
ManifestType: installer
ManifestVersion: 1.1.0

turns into

# Created using wingetcreate 0.4.3.1
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.1.0.schema.json

PackageIdentifier: AnyDeskSoftwareGmbH.AnyDesk
PackageVersion: ad 7.0.3
Platform:
- Windows.Desktop
MinimumOSVersion: 10.0.0.0
Scope: machine
InstallModes:
- interactive
- silent
- silentWithProgress
Installers:
- Architecture: x86
  InstallerType: msi
  InstallerUrl: https://download.anydesk.com/AnyDesk.msi
  InstallerSha256: 307B2EC75D5A4DB865FFA253F482263F183E86E1BCF627CE65BB45CDFCB1C295
  UpgradeBehavior: uninstallPrevious
  ProductCode: '{62853EBF-E9DD-4AA5-B20A-5A6C3DD74FF3}'
- Architecture: x86
  InstallerType: exe
  InstallerUrl: https://download.anydesk.com/AnyDesk.exe
  InstallerSha256: B95DF71D6ED6EC96FA0EB51BB33B9C5503696DF2C04CE69AE89E3EDEFD91558F
  InstallerSwitches:
    Silent: --silent
    SilentWithProgress: --silent
    Upgrade: --remove-first
    Custom: --install "C:\Program Files (x86)\AnyDesk" --update-auto --create-desktop-icon --create-shortcuts
  UpgradeBehavior: install
ManifestType: installer
ManifestVersion: 1.1.0

on another note, does ManifestVersion 1.1.0 affect wingetbot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Fix-Committed
Projects
None yet
2 participants