Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify installers that don't work under emulation #993

Closed
denelon opened this issue May 26, 2021 · 2 comments · Fixed by #1427 or #1807
Closed

Identify installers that don't work under emulation #993

denelon opened this issue May 26, 2021 · 2 comments · Fixed by #1427 or #1807
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone
v1.3-Client

Comments

@denelon
Copy link
Contributor

denelon commented May 26, 2021

Description of the new feature/enhancement

Some installers do not work under emulation. The Windows Package Manager client would try to install these under emulation. There should be a mechanism to identify known architectures where a package shouldn't be installed or wouldn't work correctly.

Proposed technical implementation details (optional)
@denelon denelon added the Issue-Feature This is a feature request for the Windows Package Manager client. label May 26, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label May 26, 2021
@denelon denelon added Area-Manifest This may require a change to the manifest and removed Needs-Triage Issue need to be triaged labels May 26, 2021
@denelon
Copy link
Contributor Author

denelon commented Jun 30, 2021

How about:

InstallerArchitecture: x86
UnsupportedOSArchitectures: 
  - ARM64
  - ARM

@denelon denelon added this to the v.Next - Windows Package Manager milestone Jul 1, 2021
@denelon denelon mentioned this issue Jul 1, 2021
Closed
@denelon
Copy link
Contributor Author

denelon commented Oct 1, 2021

winget-cli/schemas/JSON/manifests/v1.1.0/manifest.installer.1.1.0.json

Lines 371 to 384 in 5a97e26

"UnsupportedOSArchitectures": {
"type": [ "array", "null" ],
"uniqueItems": true,
"items": {
"type": "string",
"enum": [
"x86",
"x64",
"arm",
"arm64"
]
},
"description": "List of OS architectures the installer does not support"
},

@denelon denelon linked a pull request Oct 1, 2021 that will close this issue
Add support for remaining manifest v1.1 fields #1427
Merged
@denelon denelon added this to WinGet Oct 1, 2021
@florelis florelis mentioned this issue Dec 16, 2021
Merged
@ghost ghost added the In-PR Issue related to a PR label Dec 16, 2021
Repository owner moved this from In Progress to Done in WinGet Jan 5, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Jan 5, 2022
@Trenly Trenly mentioned this issue Feb 28, 2022
Open
@denelon denelon modified the milestones: v.Next-Client, v1.3-Client Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
WinGet
Archived in project
Milestone
v1.3-Client
1 participant
@denelon