Trim whitespace from DisplayVersion before attempting to parse it as a version number

[KaranKad]

Description

I submitted this pull request at microsoft/winget-pkgs#16094 to fix winamp's version to the one that it reported in settings.

But since then, winget upgrade command keeps showing that winamp has a update, I think this wasn't the issue until my pull request was merged, so how is that the version reported in the settings wrong.

[denelon]

@KaranKad it takes time after the PR is merged to go through the publishing pipeline ultimately landing in the PreIndexed package for your local machine to pull down. Is this still happening? I'm also not sure how Winamp is reported in Add / Remove Programs.

[KaranKad]

Still happening

[denelon]

@ItzLevvie or @OfficialEsco or @jedieaston

Any ideas on this one?

[OfficialEsco]

Any ideas on this one?

This most be a winget-cli issue because the manifest is correct and there is nothing we can do. My +1 meant can confirm.
You can replicate this by doing winget install winamp; winget upgrade.

[ItzLevvie]

@denelon: Any ideas on this one?

Seems like the Winamp developers added a space after version number, so rather than the Control Panel displaying it as 5.8, it's actually 5.8 .

It can probably be fixed if #1073 is added since Windows only allows spaces between characters rather than after the characters in folder names.

[ItzLevvie]

A workaround for those encountering this issue: reg add HKLM\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\Winamp /v DisplayVersion /d 5.8 /f

[Trenly]

@denelon - just an idea here; Should this be a CLI issue? Feature request to trim whitespace from DisplayVersion before attempting to parse it as a version number? Similar to the request for better support for preambles

[Trenly]

• Trim Version When Parsing #4554