Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaximumOSVersion and/or SupportedOSVersions to manifest #2209

Open
Trenly opened this issue Jun 1, 2022 · 5 comments
Open

Add MaximumOSVersion and/or SupportedOSVersions to manifest #2209

Trenly opened this issue Jun 1, 2022 · 5 comments
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@Trenly
Copy link
Contributor

Trenly commented Jun 1, 2022

Description of the new feature / enhancement

The manifest currently allows for a MinimumOSVersion to distinguish apps which cannot be installed on older versions of the OS. However, there are also some packages (see microsoft/winget-pkgs#62490) which cannot be installed on newer versions of the OS such as Windows 11. This compatibility issue should be able to be placed in the manifest

Proposed technical implementation details

  1. Implement a field in the manifest for fully defining OS version support
  2. Do something with that information
@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label Jun 1, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label Jun 1, 2022
@krystofkrticka
Copy link

krystofkrticka commented Jun 1, 2022

I don't know about you but this package installs and runs just fine on my Windows 11 installation. microsoft/winget-pkgs#62490

@Trenly
Copy link
Contributor Author

Trenly commented Jun 1, 2022

I don't know about you but this package installs and runs just fine on my Windows 11 installation. microsoft/winget-pkgs#62490

In the ShortDescription field of the manifest in that PR it says:

ShortDescription: Spacedesk Driver Software for Windows PRIMARY PC (server) runs only with Windows 10, windows 8.1 and windows 7.

I didn't validate whether or not it actually ran or not. Either way, the fact still remains that the manifest currently has no concept of MaximumOSVersion

@krystofkrticka
Copy link

Oh I see that might be description, before Windows 11 was released because even on official website it says that it runs on Windows 10/11 this package in particular does not run on older version than Windows 10. I'll make another PR and fix it.

@krystofkrticka
Copy link

That's true. Especially windows terminal is annoying on Windows 10 when it show that newer version is available but that version is for Windows 11.

@krystofkrticka
Copy link

In the ShortDescription field of the manifest in that PR it says:

ShortDescription: Spacedesk Driver Software for Windows PRIMARY PC (server) runs only with Windows 10, windows 8.1 and windows 7.

OK I fixed this in PR microsoft/winget-pkgs#62502

@denelon denelon added Area-Manifest This may require a change to the manifest and removed Needs-Triage Issue need to be triaged labels Jun 1, 2022
@denelon denelon added this to the v.Next-Client milestone Aug 11, 2022
@denelon denelon removed this from the v.Next-Client milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

3 participants