Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional AppsAndFeaturesEntry fields for ARP Matching #2183

Open
Trenly opened this issue May 24, 2022 · 3 comments
Open

Additional AppsAndFeaturesEntry fields for ARP Matching #2183

Trenly opened this issue May 24, 2022 · 3 comments
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@Trenly
Copy link
Contributor

Trenly commented May 24, 2022

Description of the new feature / enhancement

In the AppsAndFeaturesEntry, there are additional fields which could be used for ARP Matching if they were added to the manifest and were populated by package maintainers. Any available ARP fields could be added to the manifest to improve ARP Matching

Proposed technical implementation details

AppsAndFeaturesEntries:
  - DisplayName: # This already exists
    Publisher: # This already exists
    DisplayVersion: # This already exists
    ProductCode: # This already exists
    UpgradeCode: # This already exists
    InstallerType: # This already exists
    HelpLink: # This is new
    UrlInfoAbout: # This is new
    URLUpdateInfo: # This is new
    EstimatedSize: # This is new
@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label May 24, 2022
@ghost ghost added the Needs-Triage Issue need to be triaged label May 24, 2022
@denelon denelon added Area-Manifest This may require a change to the manifest and removed Needs-Triage Issue need to be triaged labels May 24, 2022
@denelon
Copy link
Contributor

denelon commented Aug 11, 2022

@Trenly how are these related to matching? When would you see a user wanting to see these?

@Trenly
Copy link
Contributor Author

Trenly commented Aug 11, 2022

@Trenly how are these related to matching? When would you see a user wanting to see these?

When a user forks an open source application and begins to distribute their own version, especially with nullsoft based applications, there are times that the Display Name, Product Code, etc are left unchanged, but items like the HelpLink automatically change to show which repository compiled the application. This has a low (but non-zero) chance of overlapping with existing package ARP entries unless the additional fields are considered.

It would also be helpful to write some of these fields, such as UrlInfoAbout and HelpLink when installing portable apps.

Finally, some apps published by NVIDIA all have the same ProductCode and version, but differ by their EstimatedSize entry.

(Also, just for the sake of completeness)

@denelon
Copy link
Contributor

denelon commented Aug 11, 2022

Cool. Thanks for the clarification. I'm going to have to move this out, but I wanted to understand the context. We're going to bump the schema version to match the client version for 1.4. I'll be updating issues accordingly.

@denelon denelon added this to the v1.5-Client milestone Aug 11, 2022
@denelon denelon added this to WinGet Jan 5, 2023
@denelon denelon moved this to To Do in WinGet Jan 5, 2023
@denelon denelon modified the milestones: v1.5-Client, v.Next-Client Jun 6, 2023
@denelon denelon removed this from WinGet Jun 13, 2023
@denelon denelon removed this from the v.Next-Client milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

2 participants