Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winget doesn't waiting for batte.net to complete installation before moving to the next package #1111

Closed
jpbnetley opened this issue Jun 4, 2021 · 6 comments
Labels
Resolution-Duplicate Issue is a duplicate
Milestone

Comments

@jpbnetley
Copy link

Brief description of your issue

When running winget upgrade --all
When it gets to Battle.Net, winget doesn't wait for the installer to complete before upgrading the next package.

Steps to reproduce

Start the terminal as Admin.
If Battle.Net is installed, and at least 1 other package also requires an upgrade run winget upgrade --all
winget will start to upgrade Battle.Net

Expected behavior

winget waits for for the Battle.Net installer to complete before moving to the next package to upgrade.

Actual behavior

Once the installer starts, the Battle.Net installer downloads the update separately.
While this is happening, winget states the package is successfully installed
But the Battle.Net installer is still doing the update.
winget battle net

Environment

[winget --info]
Windows Package Manager version:  v1.0.11451
Windows: Windows.Desktop version: v10.0.19043.985
Package: Microsoft.DesktopAppInstaller version:  v1.11.11451.0

Any other software?

I am not sure if I should log this under winget-cli or under winget-pkgs

@ghost ghost added the Needs-Triage Issue need to be triaged label Jun 4, 2021
@jpbnetley
Copy link
Author

I see something similar was discussed with discord here: #189 (comment)
Might be related.

@denelon
Copy link
Contributor

denelon commented Jun 4, 2021

@jpbnetley #418 looks like a possible duplicate.

@jpbnetley
Copy link
Author

@jpbnetley #418 looks like a possible duplicate.

Yea I think the fix for discord should fix it for Battle.Net.
Not sure if its package specific or if its handled by winget.

If it is the same, I apologise for the inconvenience.
You may close this then :)

@denelon
Copy link
Contributor

denelon commented Jun 4, 2021

No worries 😊

It's hard to find duplicates in an active project. Not to mention one that spans multiple repositories.

Duplicate of #418

@ghost
Copy link

ghost commented Jun 4, 2021

@jpbnetley we've identified this Issue as a duplicate of another one that already exists. This specific instance is being closed in favor of tracking the concern over on the referenced Issue. Thanks for your report! Be sure to add your 👍 to the other issue to help raise the priority.

@ghost ghost closed this as completed Jun 4, 2021
@ghost ghost added Resolution-Duplicate Issue is a duplicate and removed Needs-Triage Issue need to be triaged labels Jun 4, 2021
@jpbnetley
Copy link
Author

@denelon Hats off to you guys keeping track of duplicate issues across multiple repos 👏

@denelon denelon added this to the v1.3-Client milestone Jun 21, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate Issue is a duplicate
Projects
None yet
Development

No branches or pull requests

2 participants