Remove use of Invoke-Expression in test script (#2921)

microsoft · Feb 3, 2023 · 27a055e · 27a055e
1 parent badb1f2
commit 27a055e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/tools/CorrelationTestbed/InSandboxScript.ps1 b/tools/CorrelationTestbed/InSandboxScript.ps1
@@ -75,21 +75,21 @@ Write-Host @"
 
 $installAndCorrelateOutPath = Join-Path $OutputPath "install_and_correlate.json"
 
-$installAndCorrelationExpression = Join-Path $desktopPath "InstallAndCheckCorrelation\InstallAndCheckCorrelation.exe"
-$installAndCorrelationExpression = -join($installAndCorrelationExpression, ' -id "', $PackageIdentifier, '" -src "', $SourceName, '" -out "', $installAndCorrelateOutPath, '"')
+$installAndCheckCorrelationExe = Join-Path $desktopPath "InstallAndCheckCorrelation\InstallAndCheckCorrelation.exe"
+$installAndCheckCorrelationArgs = @('-id', $PackageIdentifier, '-src', $SourceName, '-out', $installAndCorrelateOutPath)
 
 if ($UseDev)
 {
-  $installAndCorrelationExpression = -join($installAndCorrelationExpression, ' -dev')
+  $installAndCheckCorrelationArgs += '-dev'
 }
 
 if ($MetadataCollection)
 {
   $wingetUtilPath = Join-Path $PSScriptRoot "WinGetUtil.dll"
-  $installAndCorrelationExpression = -join($installAndCorrelationExpression, ' -meta "', $wingetUtilPath, '" -sys32 "', $System32Path,'"')
+  $installAndCheckCorrelationArgs += ('-meta', $wingetUtilPath, '-sys32', $System32Path)
 }
 
-Invoke-Expression $installAndCorrelationExpression
+& $installAndCheckCorrelationExe $installAndCheckCorrelationArgs
 
 Write-Host @"