Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows-bindgen doesn't generate noexcept methods correctly in a composable hierarchy #3257

Closed
kennykerr opened this issue Sep 5, 2024 · 0 comments · Fixed by #3262
Closed

windows-bindgen doesn't generate noexcept methods correctly in a composable hierarchy #3257

kennykerr opened this issue Sep 5, 2024 · 0 comments · Fixed by #3262
Labels
bug Something isn't working

Comments

@kennykerr
Copy link
Collaborator

Summary

It depends on ? for vtable resolution but such methods cannot use error propagation. Fortunately, these casts are infallible.

Crate manifest

No response

Crate code

No response
@kennykerr kennykerr added the bug Something isn't working label Sep 5, 2024
@kennykerr kennykerr mentioned this issue Sep 5, 2024
Merged
@kennykerr kennykerr changed the title windows-bindgen doesn't generate noexecept methods correctly in a composable hierarchy windows-bindgen doesn't generate noexcept methods correctly in a composable hierarchy Sep 6, 2024
@kennykerr kennykerr mentioned this issue Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow noexcept methods in a composable hierarchy microsoft/windows-rs
1 participant
@kennykerr