Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A TryFrom<&str> impl for GUID #3174

Closed
keehun-cf opened this issue Jul 23, 2024 · 3 comments · Fixed by #3193
Closed

A TryFrom<&str> impl for GUID #3174

keehun-cf opened this issue Jul 23, 2024 · 3 comments · Fixed by #3193
Labels
enhancement New feature or request

Comments

@keehun-cf
Copy link

keehun-cf commented Jul 23, 2024

Suggestion

Dear windows-rs team,

If I were to contribute a impl TryFrom<&str> for GUID as a pull request, would that be welcomed?

The current impl From<&str> for GUID causes panics on invalid GUID strings which I would like to avoid.

If the windows-rs team does not yet want to introduce Result types, then I'd also be okay with a function that returns Option<GUID>—I'm don't necessarily need a function that returns a Result.

Thank you!

@keehun-cf keehun-cf added the enhancement New feature or request label Jul 23, 2024
@kennykerr
Copy link
Collaborator

There is a Result type provided by the windows-core crate that you can use. Feel free to contribute a TryFrom implementation.

@cf-rhett
Copy link

@kennykerr is there documentation on the cadence for which the repo publishes to crates.io. Been hoping to use this for a while but noticed we're still at 0.58.0 on crates.io https://crates.io/crates/windows/versions

@kennykerr
Copy link
Collaborator

Crates are published as needed to avoid version churn. So there won't be a release unless there's a specific need or request for a specific crate to be updated. Generally developers will test against the repo and when they themselves are ready to publish they will then request a release.

A good example is today's 0.60.0 release that was requested by rustup after much validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants