Address most Clippy warnings in test code (#3691)

Author: kennykerr

crates/libs/version/src/lib.rs

@@ -78,6 +78,7 @@ impl OSVERSIONINFOEXW {
 }
 
 #[cfg(test)]
+#[allow(clippy::nonminimal_bool)] // explicit logic is intentionally being tested
 mod test {
     use super::OsVersion;
     use std::sync::RwLock;

crates/tests/libs/bindgen/tests/deps.rs

@@ -1,6 +1,7 @@
 use test_bindgen::deps::*;
 
 #[test]
+#[allow(clippy::manual_c_str_literals)] // false positive
 fn test() {
     unsafe {
         let library = LoadLibraryExA(
@@ -11,7 +12,10 @@ fn test() {
 
         assert!(!library.is_null());
         let address = GetProcAddress(library, "GetTickCount\0".as_ptr()).unwrap();
-        let fp = core::mem::transmute::<_, extern "system" fn() -> u32>(address);
+        let fp = core::mem::transmute::<
+            unsafe extern "system" fn() -> isize,
+            extern "system" fn() -> u32,
+        >(address);
         assert_ne!(fp(), 0);
         FreeLibrary(library);
     }

crates/tests/libs/future/tests/futures.rs

@@ -45,6 +45,7 @@ fn stream_async() -> Result<()> {
 }
 
 #[test]
+#[allow(clippy::async_yields_async)] // don't want to disturb concurrency testing
 fn switch_context() -> Result<()> {
     use futures::{executor::LocalPool, future, task::SpawnExt};
     use std::future::IntoFuture;

crates/tests/libs/implement/tests/generic_primitive.rs

@@ -38,7 +38,7 @@ impl IIterable_Impl<i32> for Thing_Impl {
 #[test]
 fn test_implement() -> Result<()> {
     let v: IVectorView<i32> = Thing().into();
-    assert_eq!(012, v.GetAt(012)?);
+    assert_eq!(12, v.GetAt(12)?);
     assert_eq!(123, v.Size()?);
     let mut index = 0;
     assert!(v.IndexOf(456, &mut index)?);

crates/tests/libs/registry/tests/string.rs

@@ -3,6 +3,7 @@ use windows_registry::*;
 use windows_strings::*;
 
 #[test]
+#[allow(clippy::unnecessary_to_owned)] // intentionally testing convertible types
 fn string() -> Result<()> {
     let test_key = "software\\windows-rs\\tests\\string";
     _ = CURRENT_USER.remove_tree(test_key);

crates/tests/libs/strings/tests/bstr.rs

@@ -19,14 +19,14 @@ fn clone() {
 
     let a = BSTR::default();
     assert!(a.is_empty());
-    assert!(a.len() == 0);
+    assert_eq!(a.len(), 0);
     let b = a.clone();
     assert_eq!(a, "");
     assert_eq!(b, "");
 
     let a = BSTR::new();
     assert!(a.is_empty());
-    assert!(a.len() == 0);
+    assert_eq!(a.len(), 0);
     assert_eq!(a.len(), 0);
     assert_eq!(a.len(), 0);
 
@@ -40,11 +40,11 @@ fn clone() {
 
     let a: BSTR = "".into();
     assert!(a.is_empty());
-    assert!(a.len() == 0);
+    assert_eq!(a.len(), 0);
 
     let a: BSTR = unsafe { SysAllocStringLen(None) };
     assert!(a.is_empty());
-    assert!(a.len() == 0);
+    assert_eq!(a.len(), 0);
 
     let a = BSTR::from("a");
     assert_eq!(a, String::from("a"));

crates/tests/libs/strings/tests/hstring.rs

@@ -2,6 +2,7 @@ use windows::core::Result;
 use windows_strings::*;
 
 #[test]
+#[allow(clippy::cmp_owned)] // intentionally testing how operations work
 fn hstring_works() {
     assert_eq!(std::mem::size_of::<HSTRING>(), std::mem::size_of::<usize>());
     let empty = HSTRING::new();
@@ -321,6 +322,7 @@ extern "C" {
     pub fn wcslen(s: *const u16) -> usize;
 }
 
+#[allow(clippy::upper_case_acronyms)]
 mod sys {
     windows_link::link!("api-ms-win-core-winrt-string-l1-1-0.dll" "system" fn WindowsCreateStringReference(sourcestring: PCWSTR, length: u32, hstringheader: *mut HSTRING_HEADER, string: *mut HSTRING) -> HRESULT);
     windows_link::link!("api-ms-win-core-winrt-string-l1-1-0.dll" "system" fn WindowsDeleteString(string: HSTRING) -> HRESULT);

crates/tests/libs/targets/tests/symbol.rs

@@ -11,10 +11,7 @@ fn symbol() {
     unsafe {
         use windows::Win32::Security::Authentication::Identity::RtlGenRandom;
         let mut buffer = [0u8; 8];
-        assert_eq!(
-            RtlGenRandom(buffer.as_mut_ptr() as _, buffer.len() as u32),
-            true
-        );
+        assert!(RtlGenRandom(buffer.as_mut_ptr() as _, buffer.len() as u32),);
         assert_ne!(&buffer, &[0u8; 8]);
     }
 }

crates/tests/misc/arch_feature/tests/sys.rs

@@ -1,5 +1,6 @@
 #[test]
 #[cfg(target_arch = "x86_64")]
+#[allow(clippy::unnecessary_literal_unwrap)] // callback type is intentionally being tested
 fn test() {
     use windows_sys::{
         Win32::System::Diagnostics::Debug::CONTEXT,

crates/tests/misc/arch_feature/tests/win.rs

@@ -1,5 +1,6 @@
 #[test]
 #[cfg(target_arch = "x86_64")]
+#[allow(clippy::unnecessary_literal_unwrap)] // callback type is intentionally being tested
 fn test() {
     use windows::{
         Win32::System::Diagnostics::Debug::CONTEXT,