-
Notifications
You must be signed in to change notification settings - Fork 102
fix: use latest version of ucx in the WDKContent as default #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8d3c85f
fix: use latest version of ucx in the WDKContent (instead of 1.6) as …
svasista-ms 32ec79a
fix: simplify error message for missing UCX version directories
svasista-ms e31e31b
fix(ci): remove Ge WDK Include and Lib folders to ensure Ni WDK is used
svasista-ms 7f3fbfb
refactor: rename arch_sdk_library_path to sdk_library_path
svasista-ms ffd6a04
test: more cases for find_max_version_in_directory function
svasista-ms f3c5947
refactor: enhance BasicVersion methods with #[must_use] attribute and…
svasista-ms e1ec33d
fix: remove unnecessary paranthesis in rust-driver-makefile.toml
svasista-ms ca8f152
refactor: replace BasicVersion with TwoPartVersion for version handli…
svasista-ms 2471257
refactor: update find_max_version_in_directory to return Result and i…
svasista-ms f465b95
refactor: use ok_or_else instead of ok_or in find_max_version_in_dire…
svasista-ms 5bb600b
refactor: seperate tests for invalid_format_versions and parse_error_…
svasista-ms 2f4215d
refactor: error handling in wdk-build header functions
svasista-ms 8808b0e
address comments
svasista-ms 90eba10
address review comments
svasista-ms 6f64b26
address review comments
svasista-ms 7c06117
address review comments
svasista-ms 990c9e2
address review comments
svasista-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.