Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory update flag is not reset after a release #97

Open
radujipa opened this issue Feb 15, 2021 · 0 comments
Open

Mandatory update flag is not reset after a release #97

radujipa opened this issue Feb 15, 2021 · 0 comments

Comments

@radujipa
Copy link

radujipa commented Feb 15, 2021

I have recently noticed that the mandatory update flag in Partner Center does not get reset after such a release was previously made.

image

My CD pipeline uses the following template for making releases to the Store:

# template.yml

parameters:
- name: environment
  type: string
  values:
  - 'ProductionPreview'
  - 'Production'
- name: appId
  type: string
- name: mandatoryUpdate  # Always true for ProductionPreview.
  type: boolean
  default: false

jobs:
- deployment: ReleaseToMicrosoftStore
  displayName: '${{parameters.environment}} Release to Microsoft Store'
  environment: '${{parameters.environment}}'
  strategy:
    runOnce:
      deploy:
        steps:
        - ${{if eq(parameters.environment, 'ProductionPreview')}}:
          - task: store-flight@0
            displayName: 'Deploy release candidate to package flight'
            continueOnError: true
            inputs:
              serviceEndpoint: 'Windows Partner Center'
              appId: '${{parameters.appId}}'
              flightName: 'Release Candidate (Kano Testers)'
              packagePath: '$(Pipeline.Workspace)/**/!(Test)*.*upload'
              force: true
              skipPolling: false
              deletePackages: true
              numberOfPackagesToKeep: '0'
              isMandatoryUpdate: true

        - ${{if eq(parameters.environment, 'Production')}}:
          - task: store-publish@0
            displayName: 'Deploy to public submission'
            continueOnError: true
            inputs:
              serviceEndpoint: 'Windows Partner Center'
              appId: '${{parameters.appId}}'
              packagePath: '$(Pipeline.Workspace)/**/!(Test)*.*upload'
              force: true
              skipPolling: false
              deletePackages: true
              numberOfPackagesToKeep: '0'
              ${{if eq(parameters.mandatoryUpdate, true)}}:
                isMandatoryUpdate: true

The CD pipeline itself has a Mandatory Update flag that can be ticked when running it manually. This gets passed on to the template and then to the store-flight/publish tasks. I've checked the pipeline logs and the task reports that the flag is being set off with the expanded pipeline showing that the last 2 lines above are not present.

##[debug]force=true
##[debug]metadataUpdateMethod=NoUpdate
##[debug]updateImages=false
##[debug]Agent.WorkFolder=/home/vsts/work
##[debug]skipPolling=false
##[debug]deletePackages=true
##[debug]numberOfPackagesToKeep=0
##[debug]isMandatoryUpdate=false
##[debug]packagePath=/home/vsts/work/1/**/!(Test)*.*upload
##[debug]Agent.ReleaseDirectory=undefined
##[debug]packagePath=/home/vsts/work/1/**/!(Test)*.*upload
##[debug]additionalPackages=null
##[debug]nameType=AppId
##[debug]appId=9PCGN1FFNCRX
##[debug]metadataPath=/home/vsts/work/1/s
##[debug]App ID: 9PCGN1FFNCRX
##[debug]Endpoint: ***
##[debug]Force delete: true
##[debug]Metadata update type: 0
##[debug]Update images: false
##[debug]Metadata root: /home/vsts/work/1/s
##[debug]Packages: /home/vsts/work/1/ci/WindowsApp/MicrosoftStoreSandbox_1.2.22.0_x86_x64_bundle.msixupload
##[debug]skipPolling: false
##[debug]deletePackages: false
##[debug]numberOfPackagesToKeep: 0
##[debug]isMandatoryUpdate: false
##[debug]mandatoryUpdateDifferHours: null

Expected behaviour:

  1. Release to Production (mandatory is false) : Partner Center submission Mandatory Update is not ticked.
  2. Release to Production (mandatory is true) : Partner Center submission Mandatory Update is ticked.
  3. Release to Production (mandatory is false) : Partner Center submission Mandatory Update is not ticked.

Actual behaviour:

  1. Release to Production (mandatory is false) : Partner Center submission Mandatory Update is not ticked.
  2. Release to Production (mandatory is true) : Partner Center submission Mandatory Update is ticked.
  3. Release to Production (mandatory is false) : Partner Center submission Mandatory Update is ticked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant