Enable Fakes Datacollector settings to be added in design mode #2586
Conversation
|
Making this a draft because it looks like work in progress. |
test/Microsoft.TestPlatform.Common.UnitTests/Utilities/FakesUtilitiesTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.Common.UnitTests/Utilities/FakesUtilitiesTests.cs
Show resolved
Hide resolved
I planned for the VSUnitTesting side changes to go in separately, so that this can be available to users through the Microsoft.TestPlatform changes earlier |
|
|
||
| if (!commandLineOptions.IsDesignMode) | ||
| // get Fakes data collector settings | ||
| if (string.IsNullOrEmpty(Environment.GetEnvironmentVariable("_Disable_Fakes_DataCollector_Configuration"))) |
There was a problem hiding this comment.
Who would use this? We usually name env variables like this VSTEST__ (e.g. VSTEST_RUNNER_DEBUG`, and spell them in uppercase, in case some OSes would consider spelling when grabbing the variable. We also consider 0 to be off, not just null.
There was a problem hiding this comment.
This is for the users in the vstest task. By Shreyas' suggestion, if something is being enabled that wasn't before, it's best to have a fallback to be able to replicate previous behavior. I can change the var name and behavior to meet the standard in the vstest repo
…crosoft/vstest into dev/vrbhardw/fakes/vstestTask
This is to enable the VSTest V2 task scenario, where the code calling into the vstest.console cannot be overridden.
TODO:
Validate vstest task with this change on existing reposValidate VS scenarios