From 0c44f4a8025fcaa2623387177cd63306b4084fc0 Mon Sep 17 00:00:00 2001 From: Vagisha Nidhi Date: Tue, 21 May 2019 15:12:10 +0530 Subject: [PATCH 1/2] Todo changes for coverlet inproc datacollector --- src/vstest.console/Processors/CollectArgumentProcessor.cs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/vstest.console/Processors/CollectArgumentProcessor.cs b/src/vstest.console/Processors/CollectArgumentProcessor.cs index b7b54e6a67..cce43f215c 100644 --- a/src/vstest.console/Processors/CollectArgumentProcessor.cs +++ b/src/vstest.console/Processors/CollectArgumentProcessor.cs @@ -229,17 +229,15 @@ internal static class CoverletConstants /// public const string CoverletDataCollectorFriendlyName = "XPlat Code Coverage"; - /// TODO : Finalize Name /// /// Coverlet inproc data collector assembly qualified name /// - public const string CoverletDataCollectorAssemblyQualifiedName = "Microsoft.TestPlatform.Extensions.CoverletCoverageDataCollector.CoverletCoverageDataCollector, Microsoft.TestPlatform.Extensions.CoverletCoverageDataCollector, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a"; + public const string CoverletDataCollectorAssemblyQualifiedName = "Coverlet.Collector.DataCollection.CoverletInProcDataCollector, coverlet.collector, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null"; - /// TODO : Finalize codebase /// /// Coverlet inproc data collector codebase /// - public const string CoverletDataCollectorCodebase = "coverletinprocdatacollector.dll"; + public const string CoverletDataCollectorCodebase = "coverlet.collector.dll"; } } -} +} \ No newline at end of file From 158215844d4f33b23dd076752af3aedfe4e72468 Mon Sep 17 00:00:00 2001 From: Vagisha Nidhi Date: Tue, 21 May 2019 15:43:28 +0530 Subject: [PATCH 2/2] Fixing UT --- .../Processors/CollectArgumentProcessorTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/vstest.console.UnitTests/Processors/CollectArgumentProcessorTests.cs b/test/vstest.console.UnitTests/Processors/CollectArgumentProcessorTests.cs index 70651d5c97..6083d743c6 100644 --- a/test/vstest.console.UnitTests/Processors/CollectArgumentProcessorTests.cs +++ b/test/vstest.console.UnitTests/Processors/CollectArgumentProcessorTests.cs @@ -212,7 +212,7 @@ public void InitializeXPlatCodeCoverageShouldNotChangeExistingXPlatDataCollector this.settingsProvider.SetActiveRunSettings(runsettings); this.executor.Initialize("XPlat Code Coverage"); - Assert.AreEqual("\r\n\r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n", this.settingsProvider.ActiveRunSettings.SettingsXml); + Assert.AreEqual($"\r\n\r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n", this.settingsProvider.ActiveRunSettings.SettingsXml); } [TestMethod]