Skip to content

Commit c667d3a

Browse files
Haploissharwell
andauthored
Add netcoreapp1.0 support to Microsoft.TestPlatform.TestHost NuGet (#2569)
* Restore netcoreapp1.0 support for testhost * Updated nuspec files to include netstandard13 and netcoreapp10. * PR fixes Co-authored-by: Sam Harwell <[email protected]>
1 parent f2f8d72 commit c667d3a

File tree

6 files changed

+347
-150
lines changed

6 files changed

+347
-150
lines changed

scripts/build.ps1

Lines changed: 146 additions & 72 deletions
Large diffs are not rendered by default.

scripts/verify-nupkgs.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ function Verify-Nuget-Packages($packageDirectory)
1414
Write-Log "Starting Verify-Nuget-Packages."
1515
$expectedNumOfFiles = @{
1616
"Microsoft.CodeCoverage" = 29;
17-
"Microsoft.NET.Test.Sdk" = 13;
17+
"Microsoft.NET.Test.Sdk" = 18;
1818
"Microsoft.TestPlatform" = 477;
1919
"Microsoft.TestPlatform.Build" = 19;
2020
"Microsoft.TestPlatform.CLI" = 350;
2121
"Microsoft.TestPlatform.Extensions.TrxLogger" = 33;
22-
"Microsoft.TestPlatform.ObjectModel" = 62;
22+
"Microsoft.TestPlatform.ObjectModel" = 91;
2323
"Microsoft.TestPlatform.Portable" = 566;
24-
"Microsoft.TestPlatform.TestHost" = 145;
24+
"Microsoft.TestPlatform.TestHost" = 197;
2525
"Microsoft.TestPlatform.TranslationLayer" = 121}
2626

2727
$nugetPackages = Get-ChildItem -Filter "*.nupkg" $packageDirectory | % { $_.FullName}

src/Microsoft.TestPlatform.ObjectModel/Microsoft.TestPlatform.ObjectModel.csproj

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@
3131
<ProjectReference Include="..\Microsoft.TestPlatform.CoreUtilities\Microsoft.TestPlatform.CoreUtilities.csproj" />
3232
</ItemGroup>
3333
<ItemGroup>
34-
<PackageReference Include="System.ComponentModel.EventBasedAsync" Condition="'$(TargetFramework)' == 'netstandard1.3'" Version="4.3.0" />
35-
<PackageReference Include="System.ComponentModel.TypeConverter" Condition="'$(TargetFramework)' == 'netstandard1.3'" Version="4.3.0" />
36-
<PackageReference Include="System.Reflection.TypeExtensions" Condition="'$(TargetFramework)' == 'netstandard1.3'" Version="4.3.0" />
37-
<PackageReference Include="System.Runtime.Serialization.Json" Condition="'$(TargetFramework)' == 'netstandard1.3'" Version="4.3.0" />
38-
<PackageReference Include="System.Runtime.Serialization.Primitives" Condition="'$(TargetFramework)' == 'netstandard1.3'" Version="4.3.0" />
39-
<PackageReference Include="System.Xml.XmlDocument" Condition="'$(TargetFramework)' == 'netstandard1.3'" Version="4.3.0" />
40-
<PackageReference Include="System.Xml.XPath" Condition="'$(TargetFramework)' == 'netstandard1.3'" Version="4.3.0" />
41-
<PackageReference Include="System.Xml.XPath.XmlDocument" Condition="'$(TargetFramework)' == 'netstandard1.3'" Version="4.3.0" />
4234
<PackageReference Include="System.Reflection.Metadata" Version="1.6.0" />
4335
</ItemGroup>
44-
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">
36+
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'" >
37+
<PackageReference Include="System.ComponentModel.EventBasedAsync" Version="4.3.0" />
38+
<PackageReference Include="System.ComponentModel.TypeConverter" Version="4.3.0" />
39+
<PackageReference Include="System.Reflection.TypeExtensions" Version="4.3.0" />
40+
<PackageReference Include="System.Runtime.Serialization.Json" Version="4.3.0" />
41+
<PackageReference Include="System.Runtime.Serialization.Primitives" Version="4.3.0" />
42+
<PackageReference Include="System.Xml.XmlDocument" Version="4.3.0" />
43+
<PackageReference Include="System.Xml.XPath" Version="4.3.0" />
44+
<PackageReference Include="System.Xml.XPath.XmlDocument" Version="4.3.0" />
4545
<PackageReference Include="NuGet.Frameworks" Version="4.6.4" />
4646
</ItemGroup>
4747
<ItemGroup Condition=" '$(TargetFramework)' != 'netstandard1.3' ">

src/package/nuspec/Microsoft.NET.Test.Sdk.nuspec

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222
<!-- TestHost gets shipped as ExtensionSDKs with name TestPlatform.Universal. -->
2323
<!-- Currently code coverage not supported for uap10.0. -->
2424
</group>
25+
<group targetFramework="netcoreapp1.0">
26+
<dependency id="Microsoft.TestPlatform.TestHost" version="$Version$" />
27+
<dependency id="Microsoft.CodeCoverage" version="$Version$" />
28+
</group>
2529
<group targetFramework="netcoreapp2.1">
2630
<dependency id="Microsoft.TestPlatform.TestHost" version="$Version$" />
2731
<dependency id="Microsoft.CodeCoverage" version="$Version$" />
@@ -33,10 +37,12 @@
3337
</dependencies>
3438
</metadata>
3539
<files>
40+
<file src="netcoreapp\*" target="build\netcoreapp1.0\" />
3641
<file src="netcoreapp\*" target="build\netcoreapp2.1\" />
3742
<file src="netfx\*" target="build\net40\" />
3843

3944
<file src="Microsoft.NET.Test.Sdk.props" target="buildMultiTargeting\" />
45+
<file src="Microsoft.NET.Test.Sdk.props" target="build\netcoreapp1.0\" />
4046
<file src="Microsoft.NET.Test.Sdk.props" target="build\netcoreapp2.1\" />
4147
<file src="Microsoft.NET.Test.Sdk.props" target="build\net40\" />
4248
<file src="Microsoft.NET.Test.Sdk.props" target="build\uap10.0\" />

0 commit comments

Comments
 (0)