Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added completion entry for @ts-expect-error directive #92093

Merged
merged 3 commits into from
Mar 9, 2020
Merged

Added completion entry for @ts-expect-error directive #92093

merged 3 commits into from
Mar 9, 2020

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 5, 2020

This PR follows up on microsoft/TypeScript#36014 by adding ts-expect-error as a completion directive, and recommends it over @ts-ignore in the editor walkthrough.

I'm happy to file a corresponding issue per the PR template if you'd prefer - figured a PR first would be easier if this is a no brainer. Thanks!

Fixes #92116

@JoshuaKGoldberg
Copy link
Contributor Author

Monaco's build failures are not related to this PR:

##[error]vs/editor/standalone/browser/quickInput/standaloneQuickInputServiceImpl.ts(11,30): error TS2459: Module '"../../../../platform/quickinput/common/quickInput"' declares 'IQuickPickItem' locally, but it is not exported.
##[error]vs/editor/standalone/browser/quickInput/standaloneQuickInputServiceImpl.ts(11,46): error TS2459: Module '"../../../../platform/quickinput/common/quickInput"' declares 'IPickOptions' locally, but it is not exported.
##[error]vs/editor/standalone/browser/quickInput/standaloneQuickInputServiceImpl.ts(11,60): error TS2459: Module '"../../../../platform/quickinput/common/quickInput"' declares 'QuickPickInput' locally, but it is not exported.
##[error]vs/platform/quickinput/browser/quickInput.ts(6,30): error TS2459: Module '"../common/quickInput"' declares 'IQuickPickItem' locally, but it is not exported.
##[error]vs/platform/quickinput/browser/quickInput.ts(6,46): error TS2459: Module '"../common/quickInput"' declares 'IPickOptions' locally, but it is not exported.
##[error]vs/platform/quickinput/browser/quickInput.ts(6,60): error TS2459: Module '"../common/quickInput"' declares 'QuickPickInput' locally, but it is not exported.

🙃 hooray

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 5, 2020

Change LGTM. Can you also create an issue on the VS Code side so we can track this feature and make sure we test it at the end of the iteration

@mjbvz mjbvz merged commit 72c700c into microsoft:master Mar 9, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the ts-expect-error-completion branch March 9, 2020 20:02
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 9, 2020

Thanks! This is scheduled for VS Code 1.44 and should be in the upcoming insiders builds

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS 3.9+ should suggest @ts-expect-error directives
2 participants