Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save shortcut does not work when using #99331

Closed
9at8 opened this issue Jun 4, 2020 · 2 comments
Closed

Save shortcut does not work when using #99331

9at8 opened this issue Jun 4, 2020 · 2 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension custom-editors Custom editor API (webview based editors)

Comments

@9at8
Copy link
Member

9at8 commented Jun 4, 2020

Testing #99003

I use emacs shortcuts (lfs.vscode-emacs-friendly). It seems like the save shortcut doesn't work (ctrl+x ctrl+s) when I'm using the emacs shortcut extension, but works (ctrl+s) when I'm not using the emacs extension.

https://github.com/SebastianZaha/vscode-emacs-friendly/blob/master/package.json#L535

@9at8
Copy link
Member Author

9at8 commented Jun 4, 2020

ah it might be because of the when clause in the emacs extension itself, and might not be related to the custom editor.

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 4, 2020

Yes, this is caused by editorTextFocus which for custom editors would evaluate to false

Please file an issue against the emacs extension for this

@mjbvz mjbvz closed this as completed Jun 4, 2020
@mjbvz mjbvz added *caused-by-extension Issue identified to be caused by an extension custom-editors Custom editor API (webview based editors) labels Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension custom-editors Custom editor API (webview based editors)
Projects
None yet
Development

No branches or pull requests

2 participants