Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepping/Continuing after modifying a source file does not give the debugger any updated information #9823

Closed
wesrupert opened this issue Jul 26, 2016 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@wesrupert
Copy link

  • VSCode Version: 1.4.0-Insider 2016-07-26T05:09:25.359Z

Steps to Reproduce:

  1. Set and hit a breakpoint in a C# app
  2. Write gibberish after the breakpoint, as many lines of it as you like
  3. Step over

Expected Result:

  • Stepping leads to a no source page

Actual Result:

  • Stepping steps into garbage lines, as the debugger has no idea that the expected lines aren't there

image

I'm not seeing an event come in indicating that we are now working with stale code in the window. It looks like Issue 8077 improved this behavior when the user saves, but now we need something to enable correct behavior, e.g. a "no source" page since the window no longer represents the code that the debugger thinks it's running.

@kieferrm kieferrm added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 27, 2016
@weinand weinand added this to the April 2017 milestone Apr 6, 2017
@weinand weinand added the feature-request Request for new features or functionality label Apr 6, 2017
@weinand weinand modified the milestones: On Deck, April 2017 Apr 21, 2017
@remss
Copy link

remss commented Apr 18, 2018

I don't see how we can detect that breakpoints must not be applied/verified on setBreakpoints request when the source is dirty and not saved yet.
Can the sourceModified flag be set to TRUE is this case ?

@weinand
Copy link
Contributor

weinand commented Sep 11, 2018

As soon as source is edited while a debug session is active, the breakpoints are marked as unverified and rendered as such.

@weinand weinand closed this as completed Sep 11, 2018
@remss
Copy link

remss commented Sep 11, 2018

Yes when file is dirty breakpoints are marked as unverified in the GUI but the debugger will still break on old source breakpoints (on empty lines).
I this case I believe that the paused source cannot be the local one any more but should be a read-only loaded script tab, with current active breakpoints displayed.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants