Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook: message can overflow the cell #96404

Closed
bpasero opened this issue Apr 28, 2020 · 1 comment
Closed

Notebook: message can overflow the cell #96404

bpasero opened this issue Apr 28, 2020 · 1 comment
Assignees
@rebornix @jrieken
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded web Issues related to running VSCode in the web
Milestone
April 2020

Comments

@bpasero
Copy link
Member

bpasero commented Apr 28, 2020

Refs: #96279

image

It looks like a long enough string can overflow the cell.

//cc @jrieken
@bpasero bpasero added web Issues related to running VSCode in the web notebook labels Apr 28, 2020
@jrieken
Copy link
Member

jrieken commented Apr 28, 2020

@rebornix this is error output, not "normal" output. https://github.com/microsoft/vscode-github-issue-notebooks/blob/3c2a56faa435ce4d250b9344f16f7e1432d37b80/src/notebookProvider.ts#L142

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Apr 28, 2020
@rebornix rebornix added this to the April 2020 milestone Apr 28, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
4 participants
@rebornix @bpasero @jrieken @connor4312