Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception in new terminal links #95575

Closed
Tyriar opened this issue Apr 17, 2020 · 0 comments
Closed

Exception in new terminal links #95575

Tyriar opened this issue Apr 17, 2020 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-links verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 17, 2020

Easy repro:

Split a terminal such that lines get wrapped in the terminal
Move the mouse quickly around the left terminal

terminalLinkHelpers.ts:31 Uncaught TypeError: Cannot read property 'getCell' of undefined
    at Object.convertLinkRangeToBuffer (terminalLinkHelpers.ts:31)
    at terminalWebLinkProvider.ts:45
    at Array.forEach (<anonymous>)
    at TerminalWebLinkProvider.provideLink (terminalWebLinkProvider.ts:44)
    at e:\GitHub\microsoft\vscode\node_modules\xterm\lib\xterm.js:1
    at Array.forEach (<anonymous>)
    at e._askForLink (e:\GitHub\microsoft\vscode\node_modules\xterm\lib\xterm.js:1)
    at e._onHover (e:\GitHub\microsoft\vscode\node_modules\xterm\lib\xterm.js:1)
    at e._onMouseMove (e:\GitHub\microsoft\vscode\node_modules\xterm\lib\xterm.js:1)
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-links labels Apr 17, 2020
@Tyriar Tyriar added this to the April 2020 milestone Apr 17, 2020
@Tyriar Tyriar self-assigned this Apr 17, 2020
@Tyriar Tyriar modified the milestones: April 2020, May 2020 Apr 24, 2020
@Tyriar Tyriar closed this as completed in 1a3ef44 May 15, 2020
@Tyriar Tyriar added the verified Verification succeeded label Jun 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-links verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

1 participant