Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White Flash in Dark Theme #95190

Closed
JHaller27 opened this issue Apr 14, 2020 · 9 comments
Closed

White Flash in Dark Theme #95190

JHaller27 opened this issue Apr 14, 2020 · 9 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@JHaller27
Copy link

JHaller27 commented Apr 14, 2020

Issue Type: Bug

System info:

  • VS Code on WSL (though also reproduced on host Windows 10)
  • System theme set to dark
  • VS Code Color Theme Preference set to "Dark+ (default dark)"

Repro steps:

  1. Open VS Code

Expected result:
VS Code opens in dark mode, without flashing white

Actual result:
VS Code flashes bright white before switching quickly to dark theme.

I do not have epilepsy, but this could certainly be a trigger. Even without epilepsy, it hurts my eyes and is rather frustrating. I'm no expert, but this feels like an accessibility violation.


VS Code version: Code 1.41.0 (9579eda, 2019-12-11T18:37:42.077Z)
OS version: Windows_NT x64 10.0.18363
Remote OS version: Linux x64 4.4.0-18362-Microsoft

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.93GB (6.86GB free)
Process Argv --folder-uri=vscode-remote://wsl+Ubuntu/win/git/md2bb --remote=wsl+Ubuntu
Screen Reader no
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 4.4.0-18362-Microsoft
CPUs Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
Memory (System) 15.93GB (6.86GB free)
VM 0%
Extensions (4)
Extension Author (truncated) Version
vscode-browser-preview auc 0.6.6
remote-wsl ms- 0.41.9
vim vsc 1.13.1
python ms- 2020.2.64397
@chrmarti
Copy link
Collaborator

Please update to the lastest version of VS Code and confirm the problem is still there.

@chrmarti chrmarti self-assigned this Apr 14, 2020
@chrmarti chrmarti added the info-needed Issue requires more information from poster label Apr 14, 2020
@kshpytsya
Copy link

Happens here as well:

Version: 1.44.0
Commit: 2aae1f2
Date: 2020-04-08T11:22:13.689Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.5.0-pf2

@JHaller27
Copy link
Author

@chrmarti Sorry, I was having issues updating (probably a WSL thing, not a VSCode thing). After updating my specs are:

Version: 1.44.1 (user setup)
Commit: a9f8623
Date: 2020-04-11T01:48:12.622Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

@rakleed
Copy link

rakleed commented Apr 20, 2020

I can also reproduce this if my VS Code was opened in full screen mode, then closed, and opened again.

@leonardopaffi
Copy link

leonardopaffi commented Apr 22, 2020

I have the same issue with Dropdown Menus (File, Edit, Selection, ...). Clicking on a menu causes a white flash.

Version: 1.44.1
Commit: a9f8623
Date: 2020-04-16T21:41:21.848Z
Electron: 7.1.14
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.4.33-3-MANJARO

Edit: I found it's an Electron issue electron/electron#18184
Edit2: Upgrading to Electron 8.1.1 should solve this issue

@deepak1556
Copy link
Collaborator

@JHaller27 would be good to check if our exploration build that has Electron 8 runtime fixes the issue #94074 (comment)

@Shindanaide the menubar issue is tracked under #80798 , please follow that for updates. Thanks!

@github-actions
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@rakleed
Copy link

rakleed commented May 18, 2020

@chrmarti please take a look.

@chrmarti
Copy link
Collaborator

@rakleed Could you:

[...] check if our exploration build that has Electron 8 runtime fixes the issue #94074 (comment)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

6 participants