Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate hover for terminal link providers #95078

Closed
Tyriar opened this issue Apr 13, 2020 · 2 comments
Closed

Differentiate hover for terminal link providers #95078

Tyriar opened this issue Apr 13, 2020 · 2 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 13, 2020

Currently hovering a validated local link and a word (that opens quick access) look exactly the same, this is important as they do different things.

Showing the URL would also be needed for when the terminal supports the hyperlink escape sequence xtermjs/xterm.js#1134
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Apr 13, 2020
@Tyriar Tyriar added this to the On Deck milestone Apr 13, 2020
@Tyriar Tyriar self-assigned this Apr 13, 2020
@Tyriar Tyriar changed the title Improve hover for terminal link providers Differentiate hover for terminal link providers Apr 19, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Apr 19, 2020

This is also useful for extensions, the VS Code API #91290 should probably have a label it can provide as well

@Tyriar Tyriar modified the milestones: On Deck, April 2020 Apr 27, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Apr 27, 2020

This will be covered in the links test plan item.

@Tyriar Tyriar closed this as completed Apr 27, 2020
@Tyriar Tyriar added feature-request Request for new features or functionality verified Verification succeeded and removed bug Issue identified by VS Code Team member as probable bug labels Apr 27, 2020
@Tyriar Tyriar mentioned this issue Apr 27, 2020
Closed
2 tasks
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Apr 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
1 participant
@Tyriar