Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about how EnvironmentVariableCollection handles multiple extensions changing the same variable #94081

Open
mjbvz opened this issue Mar 31, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc.
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 31, 2020

Refs #93601

Repro

  1. In Extension 1, create a persisted EnvironmentVariableCollection that calls .replace('TEST', 'replace')

  2. In extension 2, create a non persisted EnvironmentVariableCollection that calls .append('TEST', 'append')

  3. Install both extensions

  4. Activate extension 1.

  5. Then restart VS Code

  6. Now activate extension 2

  7. Create a new terminal and check the value of TEST

Expected
I expected TEST to be replaceappend

This is because I expect the initial value of TEST to be replace from the persisted collection in extension 1, then when extension 2 is activated it appends on its value.

Actual
The value of TEST is replace

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Apr 1, 2020
@Tyriar Tyriar added this to the March 2020 milestone Apr 1, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 1, 2020

Discussed this in the API call, the order is reverse to what it's meant to be right now.

@Tyriar Tyriar modified the milestones: March 2020, April 2020 Apr 2, 2020
@Tyriar Tyriar modified the milestones: April 2020, May 2020 Apr 30, 2020
@Tyriar Tyriar modified the milestones: May 2020, Backlog Jun 1, 2020
@Tyriar Tyriar added terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. and removed terminal General terminal issues that don't fall under another label labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc.
Projects
None yet
Development

No branches or pull requests

3 participants