Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisArg not used for EnvironmentVariableCollection #94077

Closed
mjbvz opened this issue Mar 31, 2020 · 0 comments
Closed

thisArg not used for EnvironmentVariableCollection #94077

mjbvz opened this issue Mar 31, 2020 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 31, 2020

Refs #93601

Repo

For an extension:

const collection = vscode.window.getEnvironmentVariableCollection(true);
collection.append('TEST', 'world');

collection.forEach(function (key, value, collection) {
    console.log(this);
}, {x: 1})

Bug
this is undefined inside the callback

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Apr 3, 2020
@Tyriar Tyriar added this to the April 2020 milestone Apr 3, 2020
@Tyriar Tyriar closed this as completed in 8279cc7 Apr 9, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants