[semantic][typescript] Semantic highlighting for imports should be optional

[arkthur]

In 1.43.1, it was decided that imports should no longer have semantic highlighting, but in #92740 there is an answer that shows that I'm not the only one who actually liked that feature and find it useful. I hope you consider for next upgrade to at least make it optional. Thanks in advance.

[davelsan]

Thanks for this issue. I actually spent a while debugging this, and even reported it, not checking whether it might be a feature.

Needless to say I second this proposal. Semantic highlighting in imports help me to quickly identify the type of whatever I am importing into the component.

[varog-norman]

I also like this feature and hope it will be available next releases

[Saschamz]

I'm running VSCode version 1.42 for this feature alone so I also second this 😄

[arkthur]

Hi, @aeschli. Are there any news about this feature? All I've seen is this has been delayed twice. Many people still using 1.42 because of this, including me. Is this ever going to be done? If not, I think you should say something, so we can go use some other editor/IDE that gives us what we want/need without having to stop updates.

[aeschli]

It's still on my list, but there's always other things coming up.
Anyone want to give a try, I can give some infos where to begin.

[arkthur]

Anyone want to give a try, I can give some infos where to begin.

@aeschli I'd be glad to give it a try. Hope I have what's needed. Please, give me the info I need and I'll give this as much time as I can spare.

[aeschli]

Semantic highlighting is implemented in a TypeScipt server plugin: https://github.com/aeschli/typescript-vscode-sh-plugin
The client part for semantic highlighting is here https://github.com/microsoft/vscode/blob/master/extensions/typescript-language-features/src/features/semanticTokens.ts

To send settings from the typescipt client to the plugin on the server, there's an API:

vscode/extensions/typescript-language-features/src/utils/plugins.ts

Line 60 in 856dea7

public setConfiguration(pluginId: string, config: {}) {

• define a new setting for the typesccript extension
• in /semanticTokens.ts, read and observe the setting and send it to the plugin
• in the plugin use the setting

[aeschli]

The typescript team is working on adopting our semantic highlighting code to the ts server, see microsoft/TypeScript#39119.
One done, we will move this issue in the TypeScript repo.

[arkthur]

The typescript team is working on adopting our semantic highlighting code to the ts server, see microsoft/TypeScript#39119.
One done, we will move this issue in the TypeScript repo.

Is there any news about this?

[EliasGcf]

The typescript team is working on adopting our semantic highlighting code to the ts server, see microsoft/TypeScript#39119.
One done, we will move this issue in the TypeScript repo.

Is there any news about this?

I also would like to know it

[aeschli]

Yes, semantic highlighting for TS/JS is now part of TypeScript.

[aeschli]

@arkthur @EliasGcf Do you want to file a new issue against https://github.com/microsoft/TypeScript/issues ?
The Transfer Issue feature doesn't work for this as I'm not a team member of TypeScipt and I think it's better if the new issue is filed by an interested party.

[aeschli]

Closing. Please file an issue against TypeScript if still needed