Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke test: search test failure #91451

Closed
RMacfarlane opened this issue Feb 25, 2020 · 4 comments
Closed

Smoke test: search test failure #91451

RMacfarlane opened this issue Feb 25, 2020 · 4 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug smoke-test-failure verified Verification succeeded web Issues related to running VSCode in the web
Milestone
March 2020

Comments

@RMacfarlane
Copy link
Contributor

Testing #91337

When running the Web tests with Chromium, I see this test failure:

  1) VSCode Smoke Tests (Web)
       Search
         searches for body & checks for correct result number:
     Error: Timeout: get text content '.search-view .messages .message>span' after 20 seconds.
      at /Users/ramacfar/dev/vscode/test/automation/out/code.js:176:23
      at Generator.next (<anonymous>)
      at fulfilled (/Users/ramacfar/dev/vscode/test/automation/out/code.js:9:58)
@Tyriar Tyriar added this to the February 2020 milestone Feb 25, 2020
@Tyriar Tyriar added smoke-test-failure bug Issue identified by VS Code Team member as probable bug labels Feb 25, 2020
@Tyriar Tyriar removed their assignment Feb 25, 2020
@bpasero
Copy link
Member

bpasero commented Feb 26, 2020

Seems a flaky one, I saw this only once and then it was fine.

@bpasero bpasero added the web Issues related to running VSCode in the web label Feb 26, 2020
@chrmarti
Copy link
Collaborator

Seeing the same with Webkit, screenshot:
image

@roblourens
Copy link
Member

This is due to running the search a millisecond before the provider in the EH has registered. It's only possible to hit manually if you are very fast. I want to fix SearchService to defer searches until a matching provider has registered so I'll wait for March.

@roblourens roblourens modified the milestones: February 2020, March 2020 Feb 26, 2020
@connor4312
Copy link
Member

I ran smoke tests a few times and didn't see a failure here.

@connor4312 connor4312 added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug smoke-test-failure verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
6 participants
@roblourens @bpasero @Tyriar @connor4312 @RMacfarlane @chrmarti