No DST in Brazil

[jvvasquesn]

Issue Type: Bug

The government of Brazil has announced that there will be no DST in Brazil

VS Code version: Code 1.42.0 (ae08d54, 2020-02-06T10:51:23.649Z)
OS version: Linux x64 4.15.0-76-generic

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-2640M CPU @ 2.80GHz (4 x 2766)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: disabled_software skia_renderer: disabled_off surface_control: disabled_off surface_synchronization: enabled_on video_decode: unavailable_off viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off webgl: enabled webgl2: enabled
Load (avg)	1, 1, 1
Memory (System)	5.73GB (0.26GB free)
Process Argv	--no-sandbox --unity-launch
Screen Reader	no
VM	0%

Extensions (6)

Extension	Author (truncated)	Version
activitusbar	Gru	0.0.25
todo-tree	Gru	0.0.167
svn-scm	joh	2.7.0
tds-monitor	TOT	0.0.7
tds-vscode	TOT	0.3.23
vscode-icons	vsc	9.7.0

[IllusionMH]

Could you provide more details how it affects VS Code editor?

[gusbemacbe]

@IllusionMH

I am also Brazilian. It means that your text editor still uses the traditional UTC time, and has to adapt to Brazil's time using the DST without summer adaptation.

Under our government, we will have no summer adaptation.

[IllusionMH]

Just in case - I'm not a developer.
Do you have an example where time is displayed in VS Code is or would be wrong?

Only case I can see Gitlens extension and new experimental Timeline (editor itself).

However I have big doubts that VS Code does some date/time conversions other than available in Chromium.

[gusbemacbe]

As VSCode is written in Electron, look: electron/electron#20998

[IllusionMH]

Thanks for the link. That what I implied in my previous comment, but had to be more clear - it is external issue to the editor itself and should be fixed in Chrome, Node, or Electron.

However in linked issue notes that

Last Known Working Electron version:
7 and up works

and confirmed by the comment electron/electron#20998 (comment)

Also the above ICU change is minimal and only needed for 6-1-x branch

February insiders build has Electron v7.1.11 so it shouldn't be a problem after 1.43 will be released in early March.

@deepak1556 is there anything needed to handle DST removal after 1.43 release?

[gusbemacbe]

@IllusionMH

I got, @jvvasquesn is using the current VSCode version – 1.42. I am using Insiders – the version 1.43, and installed the "Date & Time" extension to test and the time seems OK:

[deepak1556]

@IllusionMH the fix should propagate automatically, there is no change required on the app end. And yup to reiterate this is fixed in electron 7 and above. Electron won't be fixing it for earlier release lines than 7 due to the patch required in ICU.

[deepak1556]

Closing issue for milestone #91278, should be available in stable soon.