Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Go To File... allow repeat of previous search #90114

Closed
joeytwiddle opened this issue Feb 6, 2020 · 2 comments
Closed

In Go To File... allow repeat of previous search #90114

joeytwiddle opened this issue Feb 6, 2020 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@joeytwiddle
Copy link

joeytwiddle commented Feb 6, 2020

An example use case:

  • I hit Cmd-P and search for "package.json"

  • Because I'm in a monorepo, there are many files with that name. I select the one I think I wanted.

  • Oops I chose the wrong one! So I hit Cmd-P again, to look for the right one.

  • Problem: I have to type "package.json" again.

  • Solution: I should be able to press something to get the previous search text "package.json" back in the text box.

In the Find In Files search box, we can cycle previous search terms with Up and Down keys, but we cannot use those in Go To File... because they are already used to cycle through the visible list of files.

A keystroke like Cmd-Up would be fine for me.

Or any of the keys Cmd-K / O / L would be conveniently placed on US keyboards. They currently trigger completely separate features, but I think it might be reasonable to give them a different behaviour within this context. Complete keystroke: Cmd-P Cmd-K

(Alternatively, the ^ key could do this, instead of being entered as a literal character. I think that is rarely used to search filenames. Or the ! key, which nods to bash history search, although it seems that is already doing something, but I'm not sure what exactly.)

@bpasero
Copy link
Member

bpasero commented Feb 6, 2020

Configurable in settings:

image

And duplicate of #18232

@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 6, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 6, 2020

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Feb 6, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants