Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing "recently used" from first item in command palette #89816

Closed
luabud opened this issue Jan 31, 2020 · 5 comments
Closed

Consider removing "recently used" from first item in command palette #89816

luabud opened this issue Jan 31, 2020 · 5 comments
Assignees
Labels
*as-designed Described behavior is as designed info-needed Issue requires more information from poster

Comments

@luabud
Copy link
Member

luabud commented Jan 31, 2020

I'm opening this because of issue microsoft/vscode-python#9826.

When you use the "Python: Select Interpreter" command, it will display a list of available Python interpreters that you can pick from. But whenever you open the command prompt again, it will show "Python: Select Interpreter" at the top, since it was the last used command, but it will also display a "recently used" tag by its side:

image

The problem is that like we see in issue microsoft/vscode-python#9826, some people think the "recently used" is related to the command itself (i.e. in this case, "select recently used interpreter"). Since the last used command is already shown on the highlighted on the top of the list, is it really necessary to add "recently used" to its side?

@bpasero
Copy link
Member

bpasero commented Feb 3, 2020

I would not want to change this because you can see here how it is being used:

image

We use these blue group markers quite consistently throughout quick picks.

@bpasero bpasero added the info-needed Issue requires more information from poster label Feb 3, 2020
@yume-chan
Copy link
Contributor

Maybe the "recently used" should be a header instead of a tag, and "other commands" should be called "all commands"?

image

It looks pretty bad if the first command also has a keyboard shortcut.

@bpasero
Copy link
Member

bpasero commented Feb 6, 2020

Commands which are in the "recently used" bucket are not in "other commands" so we cannot really rename it to "all commands".

@yume-chan
Copy link
Contributor

Commands which are in the "recently used" bucket are not in "other commands" so we cannot really rename it to "all commands".

@bpasero Oh I never knew that. My expectation was the two buckets are only sorted differently (by recently used or alphabetically).

@bpasero bpasero added the *as-designed Described behavior is as designed label Feb 11, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 11, 2020

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Feb 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants