Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Frame shown on async part of stacktrace #89471

Closed
chrmarti opened this issue Jan 28, 2020 · 5 comments
Closed

Restart Frame shown on async part of stacktrace #89471

chrmarti opened this issue Jan 28, 2020 · 5 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@chrmarti
Copy link
Collaborator

#89393 testing on Windows.

Restart Frame is shown on past parts of the stacktrace. It doesn't work:
image

@connor4312
Copy link
Member

Previous discussion: #84045 (comment)

cc @isidorn @weinand. Mentioned there, I think the most reliably way would be to have an annotation from the debug adapter indicating whether or not each stack frame can be restarted.

@connor4312 connor4312 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jan 28, 2020
@connor4312 connor4312 added the feature-request Request for new features or functionality label Nov 4, 2020
@connor4312 connor4312 modified the milestones: Backlog Candidates, Backlog Nov 4, 2020
@microsoft microsoft deleted a comment Nov 5, 2020
@isidorn
Copy link
Contributor

isidorn commented Nov 5, 2020

If we do not introduce a new annotation for this the best I could do from the UX side is to not show Restart Frame action on deemphasize stack frames.
What do you think about that approach?

@connor4312
Copy link
Member

I think an annotation would be better. I'm not sure using deemphasis alone as the boundary is totally correct for js-debug, and may not work for other debuggers.

@weinand
Copy link
Contributor

weinand commented Mar 15, 2021

@connor4312 this can be closed, right?

@isidorn
Copy link
Contributor

isidorn commented Mar 15, 2021

I tried this out and was working fine for me. Thus closing this and @connor4312 can reopen if needed

@isidorn isidorn closed this as completed Mar 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants
@weinand @isidorn @connor4312 @chrmarti and others