Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: ESLint support for TypeScript #85933

Closed
2 tasks done
dbaeumer opened this issue Dec 2, 2019 · 1 comment
Closed
2 tasks done

Test: ESLint support for TypeScript #85933

dbaeumer opened this issue Dec 2, 2019 · 1 comment

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Dec 2, 2019

Tests microsoft/vscode-eslint#802

Complexity: 3

The ESLint extension now has better support for TypeScript. Test that this is working as expected if a workspace is setup correctly for eslint usage.

Prerequisite

Install the latest version of the ESLint extension from here: https://github.com/microsoft/vscode-eslint/releases/tag/2.0.1-next.1

Setup

  • create a new workspace folder
  • add eslint to it
  • add typescript to it.
  • add the typescript parser to it: "@typescript-eslint/parser
  • create a .eslintrc.json file and configure the typescript parse
	"parser": "@typescript-eslint/parser",
	"parserOptions": {
		"ecmaVersion": 6,
		"sourceType": "module"
	}
  • create a TypeScript file

A blueprint repository can be found here: https://github.com/microsoft/vscode-eslint/tree/2.0.1-next.1/playgrounds/ts

Ensure the following:

  • the TypeScript file is validated correctly
  • for workspace that don't have TypeScript support enabled for eslint no error messages are shown and no Output panels pop to the front.

Please report issues here: https://github.com/microsoft/vscode-eslint/issues

@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2019

Works nicely. I also set it up for our VS Code repo. I tested on macOS.

@sana-ajani sana-ajani removed their assignment Dec 3, 2019
@chrmarti chrmarti closed this as completed Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants