Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab high contrast border shifts tab text when active #8551

Closed
Tyriar opened this issue Jun 30, 2016 · 4 comments
Closed

Tab high contrast border shifts tab text when active #8551

Tyriar opened this issue Jun 30, 2016 · 4 comments
Assignees
@bpasero @bgashler1
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) workbench-tabs VS Code editor tab issues
Milestone
June 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2016

#7854

  • VSCode Version: Code - Insiders 1.3.0-insider (798b41a, 2016-06-29T05:14:50.570Z)
  • OS Version: Linux x64 4.4.0-24-generic

Notice the text is aligned slightly differently. Whenever you make a tab active, both the previously active and the new active tab text shifts by 1 px. I think it may also shift horizontally too.

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug workbench accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues workbench-tabs VS Code editor tab issues labels Jun 30, 2016
@Tyriar Tyriar mentioned this issue Jun 30, 2016
Closed
@bpasero bpasero assigned bgashler1 and unassigned bpasero and Tyriar Jun 30, 2016
@bpasero
Copy link
Member

bpasero commented Jun 30, 2016

When you enable HC mode, for me many areas of the UI have this issue, not just tabs. I do not think this is a big deal but moving to our HC master @bgashler1

@bgashler1
Copy link
Contributor

Yeah, that bothered me too. It's fixed in my latest PR #8238.

Borders were offsetting the active tab, so I added transparent borders on all inactive tabs.

@bpasero bpasero self-assigned this Jun 30, 2016
@bpasero bpasero added this to the June 2016 milestone Jun 30, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Jun 30, 2016

outline is typically used for this over border as the outline is overlayed on top, not inserted around the element.

@bpasero bpasero mentioned this issue Jun 30, 2016
Closed
@bpasero
Copy link
Member

bpasero commented Jun 30, 2016

#8564

@bpasero bpasero closed this as completed Jun 30, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@bgashler1 bgashler1

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @bgashler1