Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to definition is broken in VS Code Insiders #85403

Closed
snjeza opened this issue Nov 22, 2019 · 3 comments
Closed

Go to definition is broken in VS Code Insiders #85403

snjeza opened this issue Nov 22, 2019 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@snjeza
Copy link

snjeza commented Nov 22, 2019

  • VSCode Version: VS Code Insiders 1.41
  • OS Version: Fedora 30

Steps to Reproduce:

VS Code Insiders:

tcode-insiders

VS Code 1.40.1

tcode

Related issue: eclipse-jdtls/eclipse.jdt.ls#1281 (comment)

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 22, 2019

Text:

class a {
    constructor() {
        this.test();
    }
    test() {}
}

@jrieken I think this is an intentional change for #73081

@mjbvz mjbvz assigned jrieken and unassigned mjbvz Nov 22, 2019
@jrieken
Copy link
Member

jrieken commented Nov 25, 2019

Yes, that's the new design: Going to definition on a definition -> Run Go to References -> Running to references with a single result -> To go single reference. Anways, this can also be configured via editor.gotoLocation.alternativeDefinitionCommand, e.g an empty value will disable this behaviour

@jrieken jrieken closed this as completed Nov 25, 2019
@jrieken jrieken added the *as-designed Described behavior is as designed label Nov 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

4 participants
@snjeza @jrieken @mjbvz and others