Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand selection doesnt honor editor.wordSeparators #8440

Closed
TobiaszCudnik opened this issue Jun 28, 2016 · 4 comments
Closed

Expand selection doesnt honor editor.wordSeparators #8440

TobiaszCudnik opened this issue Jun 28, 2016 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)

Comments

@TobiaszCudnik
Copy link

  • VSCode Version:
  • OS Version:

Steps to Reproduce:

  1. Set editor.wordSeparators to "_"
  2. Try to expand selection (alt+shift+right on linux) on "^a_b"

Expected: "^a$_b"
Result: "^a_b$"

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug editor labels Jun 29, 2016
@alexdima alexdima assigned jrieken and unassigned alexdima Jun 29, 2016
@jrieken jrieken added the help wanted Issues identified as good community contribution opportunities label Jun 29, 2016
@jrieken
Copy link
Member

jrieken commented Jun 29, 2016

Yes - it's based on the tokinizer info and not on word info. The whole thing should be redone

@TobiaszCudnik
Copy link
Author

Glad to hear that it's gonna be redone. Its one of the missing features for me after switching from webstorm.

@rozzzly
Copy link

rozzzly commented Jun 29, 2016

I totally agree with Tobias, webstorm's selection grow is awesome and I miss it dearly. There are a few extensions on the marketplace expand upon vscode's native functionality, but even with them, its still interior to webstorm's implementation imho.

@jrieken jrieken added *duplicate Issue identified as a duplicate of another issue(s) and removed help wanted Issues identified as good community contribution opportunities labels Jul 5, 2016
@jrieken
Copy link
Member

jrieken commented Jul 5, 2016

Closing this as a dupe of #4795 which is also about improving/redoing word selection.

@jrieken jrieken closed this as completed Jul 13, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants