Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted domain editor: Looks like text file, but isn't #81843

Closed
aeschli opened this issue Oct 2, 2019 · 1 comment
Closed

Trusted domain editor: Looks like text file, but isn't #81843

aeschli opened this issue Oct 2, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-link Link protection in workbench

Comments

@aeschli
Copy link
Contributor

aeschli commented Oct 2, 2019

Testing #80595

  • invoke Manage Trusted Domains
  • any changes to the file are lost, only the values are kept. e.g. my formatting, commented out domains.
@aeschli aeschli changed the title Manage Trusted Domains: Looks like text file, but isn't Trusted domain editor: Looks like text file, but isn't Oct 2, 2019
@octref octref added this to the September 2019 milestone Oct 2, 2019
@octref octref added the bug Issue identified by VS Code Team member as probable bug label Oct 3, 2019
@octref
Copy link
Contributor

octref commented Oct 3, 2019

Good catch, makes sense.

To verifiers:

Verify that:

  • Manage Trusted Domains setting should preserve your commented out parts
  • When you have removed the header or end, for example by deleting the first line // Links matching one or more entries in the list below can be opened without link protection. or last line // Save this file to apply the trusted domains rules., the next time you run Manage Trusted Domains it'll be restored.

@octref octref closed this as completed in 8266e1c Oct 3, 2019
@Tyriar Tyriar added the verified Verification succeeded label Oct 4, 2019
@octref octref added the workbench-link Link protection in workbench label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-link Link protection in workbench
Projects
None yet
Development

No branches or pull requests

3 participants