Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated completions: Show strikethrough across icons or don't show at all #79945

Closed
octref opened this issue Aug 27, 2019 · 1 comment · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone

Comments

@octref
Copy link
Contributor

octref commented Aug 27, 2019

Testing #79814:

image

These strikethroughs are too thing and don't go all the way through. If we do add a strikethrough I hope it can be more clear.

Alternatively we can also remove it for now, so they stay consistent with deprecated symbols where the icons are not affected by deprecated.

image

image

@jrieken jrieken modified the milestones: September 2019, August 2019 Aug 28, 2019
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete labels Aug 28, 2019
@jrieken
Copy link
Member

jrieken commented Aug 28, 2019

Yeah, that half strikeout shouldn't happen. Today it should only be the word, that's because the icons comes as background images of a ::before-elements which text content isn't wide enough. For now, I will make sure that suggest looks like the others, later, once we have an icon font, we can revisit this.

@alexr00 alexr00 added the verified Verification succeeded label Aug 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants