Link protection UI inconsistency

[stevencl]

Issue Type: Bug
Testing: #79465
See the following:

I click the Open all links without prompt option, but can also unselect some of the links. Now I don't know what state I am in. Will all links open without a prompt, including the ones I unselected? Or will all links except for the ones I unselected open?

What I expected was that the open all links option would toggle the checked state of all links in the list.

VS Code version: Code - Insiders 1.38.0-insider (8cd00a7, 2019-08-27T06:13:54.903Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software oop_rasterization: disabled_off protected_video_decode: enabled rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.93GB (2.77GB free)
Process Argv
Screen Reader	yes
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
tslint	eg2	1.0.44
vscode-github-releases-updater	joa	0.17.0
vscode-docker	ms-	0.7.0
python	ms-	2019.8.30787
remote-containers	ms-	0.69.0
remote-ssh	ms-	0.45.6
remote-ssh-edit	ms-	0.45.6
remote-ssh-explorer	ms-	0.45.6
remote-wsl	ms-	0.39.4
vscode-remote-extensionpack	ms-	0.16.0
azure-account	ms-	0.8.4
test-search-rg	rob	0.0.3

[octref]

What I expected was that the open all links option would toggle the checked state of all links in the list.

On the other hand, if you have 10 domains checked and 10 unchecked, and clicks "Open all links without prompt", there's no way to restore the old state other than manually checking the 10 domains out of the 20. Making the first pick item behave different than other ones also doesn't feel nice — the checkbox right above it would toggle all on/off.

I feel "Open all links without prompt" is a pretty clear message. So marking this as-designed.

[stevencl]

I don't agree. In the mockup above, if I click on a link to marketplace.visualstudio.com it is ambiguous if I will be prompted or not. The entry is not checked suggesting that I will be prompted, but open all links without prompt is selected, suggesting that I won't be prompted. Which one takes precedence? How do I know that?

[stevencl]

@misolorio - what do you think?

[octref]

/cc @misolori

[miguelsolorio]

I would treat the "Open All Links" as the same as a "Select All" and select every item in the list. It is very ambiguous if you have some unselected and then "Open all links" is selected. Another option would be to disable the rest of the items when "Open all links" is checked, because that is what will trump all other selections and you want to be clear to the user what this will do especially when others are unselected.

[octref]

OK, I can try to make the quick input hide all items below the separator.

[octref]

This would involve a lot of change as we should use a completely different API to achieve this, so pushing out to next milestone.

[octref]

See #80595 (comment)