Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrated terminal on MacOS has bug. #77457

Closed
ladyrick opened this issue Jul 16, 2019 · 6 comments
Closed

integrated terminal on MacOS has bug. #77457

ladyrick opened this issue Jul 16, 2019 · 6 comments
Assignees
Labels
info-needed Issue requires more information from poster terminal General terminal issues that don't fall under another label

Comments

@ladyrick
Copy link

Issue Type: Bug

On the terminal starting, this line

export A_RANDOM_VARIABLE=231

shouldn't be executed.
But it seems to be executed quietly.
This is a bug obviously.
And I believe this bug is related to and is the cause of #70248
@Tyriar

屏幕快照 2019-07-16 下午5 21 16

BTW, what is that extra "%" in terminal window?

VS Code version: Code 1.36.1 (2213894, 2019-07-08T22:56:38.504Z)
OS version: Darwin x64 18.6.0

Extensions: none

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Jul 16, 2019
@Tyriar
Copy link
Member

Tyriar commented Jul 27, 2019

Can you share your settings.json file? Also you can try enable escape sequence logging to see if the % coming from the process or not https://github.com/Microsoft/vscode/wiki/Terminal-Issues#enabling-escape-sequence-logging

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jul 27, 2019
@ladyrick
Copy link
Author

Can you share your settings.json file?

Thank you for reply.
I delete the settings.json and disable all the extensions then test it again.
The result doesn't change.
You can test it for yourself.
zshrc.txt

@Tyriar
Copy link
Member

Tyriar commented Jul 31, 2019

Screen Shot 2019-07-31 at 11 07 49 AM

@ladyrick
Copy link
Author

ladyrick commented Aug 6, 2019

@Tyriar Did you try this?

  1. use given .zshrc file.
  2. set your default shell to zsh.
  3. totally quit vscode.
  4. start vscode.
  5. press control + ` to open the terminal.
  6. see the result.

If you start zsh from shell, it works well. But if you start zsh from vscode, it works differently.

@Tyriar
Copy link
Member

Tyriar commented Aug 10, 2019

Works fine:

Screen Shot 2019-08-10 at 7 17 22 AM

Can you try enable escape sequence logging to see if the % coming from the process or not https://github.com/Microsoft/vscode/wiki/Terminal-Issues#enabling-escape-sequence-logging

@ladyrick
Copy link
Author

Can you try enable escape sequence logging to see if the % coming from the process or not https://github.com/Microsoft/vscode/wiki/Terminal-Issues#enabling-escape-sequence-logging

Yes, it's from zsh.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants