Skip to content

Remove smooth scroll CLI #76665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpasero opened this issue Jul 5, 2019 · 1 comment · Fixed by #76944
Closed

Remove smooth scroll CLI #76665

bpasero opened this issue Jul 5, 2019 · 1 comment · Fixed by #76944
Assignees
@mjbvz
Labels
debt Code quality issues
Milestone
July 2019

Comments

@bpasero
Copy link
Member

bpasero commented Jul 5, 2019

@usernamehw @mjbvz I am a bit confused about this change, isn't it that command line arguments are being passed to Chrome/Electron anyway? Why is this needed?

Originally posted by @bpasero in #65422 (comment)
@bpasero bpasero added the debt Code quality issues label Jul 5, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 9, 2019

@usernamehw Would you like to submit a PR that reverts the original PR?

@usernamehw usernamehw mentioned this issue Jul 9, 2019
Merged
@bpasero bpasero added this to the July 2019 milestone Jul 9, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
debt Code quality issues
Projects
None yet
Milestone
July 2019
Development

Successfully merging a pull request may close this issue.

Revert "Add CLI flag to be able to disable smooth scroll in webviews"
2 participants
@bpasero @mjbvz