Wrong input box color in dark theme

[isidorn]

In light theme for input boxes we use the same background color as the one used for editor, however in dark theme that is not the case.
This becomes particularly visible when tabs are enabled as the quick open input has the same color as the empty after the tabs - looks confusing and this is the main reason why tabs visually look much better in the light theme than in the dark theme imho.

I can look into changing all the input box background colors but it is a big change and it requires UX blessing - so we can discuss it today in the ux meeting.

fyi @bpasero

[bpasero]

+1 for making all inputs the same colour as the editor.

/cc @jrieken @alexandrudima for owners of input fields in the editor (find, rename).

[isidorn]

Assigning to @bgashler1 to experiment with colors as we have agreed on our UX meeting and if we come to a conclusion give the issue back to me to implement it across vscode.

[stevencl]

We discussed and agreed that we should look at the colours used throughout the product now that we have tabs enabled. @bgashler1 - this is something you and I should talk about.

[bgashler1]

@isidorn While Steven and I collaborate holistically on evaluating our colors, iconography, etc, I think the change in this PR #8238 may dampen the problem somewhat (below).

You'll notice that the tab well is now the same color as the viewlet which—aside from being more hierarchically correct color-wise—has the benefit of being less confusing with the command palette's input box.

I'll move this to the backlog for now and we can keep this on our radar.

[vscodebot]

This feature request will not be considered in the next 6-12 months roadmap and has been closed to keep the number of issues we have to maintain manageable. See also our issue reporting guidelines.

Thanks for your understanding and happy coding!