Jump to cursor: doesn't show a warning if jumping to invalid cursor location

[dbaeumer]

Testing #76008

Title says it all.

[dbaeumer]

To reproduce try to jump to the end of the file.

[Tyriar]

Also saw this trying to jump to inside Another:

[isidorn]

@gregg-miskelly it seems like the C# adapter is returing gotoTargets for the end of the file position. This appears to be wrong. Should we move this issue to the C# extension?
Also is it possible that you sent me via email a new version of your extension which does not require a handshake so I can eaisly test this when running vscode out of source? Thank you

[gregg-miskelly]

@isidorn I think you fixed this already in #75578.

The design of gotoTargets is that it will return all possibly valid targets -- any source location that has associated code will get a target. Then if you actually try to go to that target, now we have enough context to know that that location is invalid, and we will fail to the goto request. With your fix, I believe everything will now work properly as the test case in this issue is essentially identical to my test case when I validated your fix.

If you still want a debug build, I am happy to provide.

[isidorn]

@gregg-miskelly thanks. Yeah a debug build would be great for future stuff.

[vscodebot]

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!