May 2019 Recovery Release Endgame

[rebornix]

Recovery Build

We release a recovery build with a handful of critical fixes and translation updates a few days after a release. The candidate fixes are reviewed by the development team and are assigned to the recovery milestone. We want to be restrictive about the included candidates. The mindset is "we will lose users if we do not include the fix". Here are some examples:

• data loss
• a regression that users complain loudly about in issues or twitter
• a significant performance regressions
• an issue that impacts many users as indicated by telemetry data
• an embarrassing UI glitch
• critical security fixes
• an issue that impacts extensions or is an API regression

Check list

• Create a milestone <Month> Recovery <year> @rebornix
• Bump the version number @ rebornix
• Assign candidate issues to the recovery milestone team
• Review the candidate issues, and if they pass the review assign them to the recovery milestone team
• All candidate fixes need a PR which is peer reviewed and merged to the release branch team
• Build stable for all platforms from release/1.xx branch @ rebornix
• Issues are verified on stable build and the verified label is added owner
• Check https://github.com/Microsoft/vscode/compare/release/<x.y> to ensure no other commits have been made in the release branch owner
• Update the release notes and include a link to a query for the fixed issues @gregvanl
• Smoketest stable bits (⚠️ MUST run with --stable-build argument ⚠️ )
  • Windows -
  • OS X -
  • Linux -
• Sanity check installable stable bits that have not been smoke tested
  • Windows
    • signed installer 32-bit
    • signed installer 64-bit
    • zip 32-bit
    • zip 64-bit
  • OS X -
  • Linux
    • deb package 32-bit
    • deb package 64-bit
    • rpm package 64-bit
    • rpm package 32-bit
    • archives
• Make rpm signing request @RMacfarlane
• Publish website @gregvanl
• Publish stable build owner
• Add a git tag to HEAD of release/<x.y> in format x.y.z (for vscode.d.ts download) @rebornix
• Publish rpm to repository manually @RMacfarlane
• Add a git tag to HEAD of release/<x.y> in format x.y.z

[galileo-pkm]

Why is there a (usually a few days long) delay from the release of RPM to actually uploading that package to the repository?