Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader: for a non existing import the loader throws the error only the first time #75257

Closed
isidorn opened this issue Jun 11, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 11, 2019

await import('I_DO_NOT_EXIST')

The loader correctly throws the error the first time this code is exectued.
The second time you execute the code the loader does not throw an error 🐛

Use case for me: https://github.com/Microsoft/vscode/blob/18f4630bc51a3d87c7b31d96ca9c8ea95aa649b0/src/vs/platform/sign/node/signService.ts#L14

@isidorn isidorn mentioned this issue Jun 11, 2019
6 tasks
@alexdima alexdima added this to the July 2019 milestone Jul 30, 2019
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jul 30, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Jul 30, 2019

Thanks for fixing this, created a follow up item for me #78186

@lramos15 lramos15 added the verified Verification succeeded label Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants